Add "search", "match" and "fullmatch" modes to Regexp validator #871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artempronevskiy
force-pushed
the
add-fullmatch-support-to-regexp-validator
branch
2 times, most recently
from
9ab5825 to
8fdd991
Compare
artempronevskiy
force-pushed
the
add-fullmatch-support-to-regexp-validator
branch
from
fe1584d to
0c355e6
Compare
artempronevskiy
commented
Nov 22, 2024
Comment on lines
+360
to
+361
| def __init__(self, regex, flags=0, message=None, mode="match"): | ||
| self.mode = self._validate_mode(mode) |
There was a problem hiding this comment.
From my POV it's better to validate mode value in __init__() in order to prevent the object instantiating with invalid data. in other words, validating mode value is a check of the invariant (mode field has supported value) and thus the object must not be created/instantiated if any of invariant checks failed.
|
/poke reviewers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently
Regexpvalidator supports onlyre.matchmode, but sometimes we need to usere.fullmatchorre.searchmode.Relevant issues or pull requests:
#867
What this PR does to fix the issue:
re.fullmatchandre.searchmodes along withre.matchwith full backward compatibilityValidatorSetupErrorexception to be raised if an user is trying to set up validator in a wrong wayRegexpvalidator to cover the changesdocs/fields.rstfile to show addedmodekwarg toRegexp.__init__()