Open
Conversation
Member
Author
|
Needs testing :-) |
Member
Author
|
Three example scenarios which should hopefully be supported by enabling renegotiation:
|
Member
|
Suggestion: We implement this together with use case 1 (palavatv/palava-web#8) |
Member
Author
|
Well, it is a precondition for case 1 but still a separate feature which we could also test with case 3? |
Member
Author
|
I don't think that the code for the renegotiation will change when tackling screen sharing as a next step. |
Member
True, you are right of course, case 3 only requires a mobile phone and a desktop computer to test |
No "perfect renegotiation" because that's too new and unsupported by browsers. Instead, a workaround by deferring adding the own offer: https://stackoverflow.com/questions/65059808/downward-compatibility-of-webrtc-renegotiation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roughly following https://blog.mozilla.org/webrtc/perfect-negotiation-in-webrtc/
but using @negotiationInProcess instead of @peerConnection.signalingState to
make the process a bit more readable/understandable.
Disadvantage: Rollbacks are quite new (half a year in chrome, bit more in Firefox).
But: Races should be rare and all other solutions would require a protocol change
and would make the process slower.