Do not create documents from a textDocument/rename #818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During a textDocument/rename, it is possible that Jedi proposes changes in files that have not yet been opened with textDocument/didOpen. In that case, we must put "version": None as the document version. Note that rope does not have this behavior.
Member
|
Thanks for your interest in palantir/python-language-server, @rwols! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
ccordoba12
approved these changes
Jun 18, 2020
Contributor
ccordoba12
left a comment
ccordoba12
left a comment
There was a problem hiding this comment.
Looks good to me, thanks @rwols!
Contributor
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a textDocument/rename, it is possible that Jedi proposes changes in files
that have not yet been opened with textDocument/didOpen. In that case, we must
put "version": None as the document version.
Note that rope does not have this behavior.
closes #816