Skip to content

Conversation

@BenjaminLowry
Copy link
Contributor

@BenjaminLowry BenjaminLowry commented Oct 18, 2024

Before this PR

After this PR

#649 updated some of our java test classes and practices but it wasn't gated by CI and just merged and broke our tests. This PR fixes these issues changing the way we deal with files.

Also updating publish to depend on circle-all since we just got the circle-all task.
==COMMIT_MSG==
==COMMIT_MSG==

Possible downsides?

@changelog-app
Copy link

changelog-app bot commented Oct 18, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Fix develop branch by changing file operations

Check the box to generate changelog(s)

  • Generate changelog entry

johnhany97
johnhany97 previously approved these changes Oct 18, 2024
@policy-bot policy-bot bot dismissed johnhany97’s stale review October 18, 2024 17:33

Invalidated by push of 68a6d7e

johnhany97
johnhany97 previously approved these changes Oct 18, 2024
@policy-bot policy-bot bot dismissed johnhany97’s stale review October 18, 2024 17:36

Invalidated by push of 5cdac30

@bulldozer-bot bulldozer-bot bot merged commit 50b820f into develop Oct 18, 2024
3 of 4 checks passed
@bulldozer-bot bulldozer-bot bot deleted the blowry/fix-file-operations branch October 18, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants