Add flag to enable TCP keepalives #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[skip ci]
[skip ci]
johnhany97
approved these changes
Oct 28, 2024
Contributor
Author
|
👍 |
johnhany97
approved these changes
Oct 28, 2024
|
Released 2.9.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
After this PR
Add enable_keep_alive flag to requests client to enable tcp keep alives to be sent for open connections. This addresses some issues we've seen in certain environments where connection reset errors like ConnectionResetError(104, 'Connection reset by peer')) which after investigation seems to be remediate in some cases by enabling keep alives. This has seemed to alleviate the issue we've seen so rolling out as an opt-in feature.
In favor of #161 which has some policy bot issues.
==COMMIT_MSG==
==COMMIT_MSG==
Possible downsides?