Known ip address #16
Open
Known ip address #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexeyRaga
force-pushed
the
known-ip-address
branch
from
41ad825 to
e44d9e7
Compare
dsturnbull
reviewed
May 1, 2019
| idx = fs_get_index_by_name(list, "rdata_fs"); | ||
| if (idx >= 0) { | ||
| list = fs_get_fieldset_by_index(list, idx); | ||
| idx = fs_get_index_by_name(list, "rdata"); |
There was a problem hiding this comment.
Do these idx values change record-by-record? If not, seems like you can bypass quite a lot of log(n) lookups via fs_get_index_by_name()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.