forked from armooo/meshview
-
Notifications
You must be signed in to change notification settings - Fork 52
Traceroutereturn: return graph path now in correct order #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jschrempp
wants to merge
13
commits into
pablorevilla-meshtastic:dev-v3
Choose a base branch
from
jschrempp:traceroutereturn
base: dev-v3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Traceroutereturn: return graph path now in correct order #99
jschrempp
wants to merge
13
commits into
pablorevilla-meshtastic:dev-v3
from
jschrempp:traceroutereturn
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added information about the new statistic page and API.
…ect data for a return route
Author
|
I don't understand the ruff error. I'm willing to fix it if someone could give me a hint on how to see what it is complaining about. Or do I just run the "let ruff reformat the web.py file" and see what happens? I'm new to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


In my last PR the graph of the return route was shown incorrectly. It did not account for the fact that the return route was in reverse order in the route blob.
This PR adds two things:
I tested this on my system with an old database and with a new database. (For testing on old database I had to comment out the route_return blob in the model.)