Skip to content

[Snyk] Security upgrade requests from 2.31.0 to 2.32.4 #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[Snyk] Security upgrade requests from 2.31.0 to 2.32.4 #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions requires-ci.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,4 @@ pyzmq==25.1.2
xlrd>=2.0.1
pytest-rerunfailures
jupyterlab<4.0.0
requests>=2.32.4 # not directly required, pinned by Snyk to avoid a vulnerability
Copy link

@gemini-code-assist gemini-code-assist bot Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This PR pins requests to version >=2.32.4 in requires-ci.txt to address Snyk vulnerability SNYK-PYTHON-REQUESTS-10305723. While this secures the CI environment, there are important considerations for comprehensive protection:

  1. Core Package Vulnerability: requests is a direct, unpinned dependency in requires-install.txt (line 9). To ensure the vulnerability is remediated for the actual distributable package and all its users, it is crucial to also add the constraint requests>=2.32.4 to requires-install.txt. Relying solely on this pin in requires-ci.txt might not protect the package if pip resolves requests to an older, vulnerable version during a standard installation (e.g., pip install .).

  2. Comment Clarity: The current comment # not directly required... is potentially misleading. Since requests is a direct dependency of the project (via requires-install.txt), it is directly required. Snyk likely means it wasn't a pre-existing top-level entry in this specific requires-ci.txt file or is a transitive dependency within the CI scope that needed an explicit pin. A more accurate comment would improve clarity.

Recommendation:
Please prioritize updating requires-install.txt to include requests>=2.32.4. For the current line in requires-ci.txt, the suggested comment below offers improved accuracy, especially if the pin is also added to requires-install.txt.

requests>=2.32.4 # Project dependency, pinned by Snyk to >=2.32.4 in CI to fix SNYK-PYTHON-REQUESTS-10305723