perf: add Memory Saver with tab suspension and exclusion list by Ayush-Vish · Pull Request #165 · p2plabsxyz/peersky-browser

Ayush-Vish · 2026-03-23T12:13:41Z

Related Issue (if any)

Closes: #164

Describe the add-ons or changes you've made

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Code style update (formatting, local variables)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Checklist:

My code follows the "contribution guidelines" of this project.
I have performed a self-review of my own code.
I have commented my code, particularly wherever it was hard to understand.
My changes generate no new warnings.
Any dependent changes have been merged and published in downstream modules.

Screenshots (Only for Front End and UI/UX Designers)

Original	Updated
Original Screenshot	Updated Screenshot

…usion management

Copilot

Pull request overview

Implements a new “Memory Saver” performance feature in PeerSky settings and tab UI to suspend inactive tabs and visually indicate sleeping tabs, with an exclusions list to keep selected sites active.

Changes:

Added new settings keys (memorySaverEnabled, memorySaverExclusions) and broadcast updates to renderer windows.
Implemented tab suspension/wake-up logic in the tab bar, including navigation-history capture/restore and hover-card memory usage updates.
Added a new “Performance” section in Settings UI with toggle + exclusions management, plus sleeping-tab styling.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
src/settings-manager.js	Adds defaults/validation and emits `memory-saver-changed` on updates.
src/pages/tab-bar.js	Implements suspend/wake logic, idle checking, exclusions matching, and hover-card async memory lookup.
src/pages/settings.html	Adds Performance section UI and navigation entry.
src/pages/static/js/settings.js	Wires up Memory Saver toggle + exclusions list UI behavior.
src/pages/theme/index.css	Adds sleeping-tab visual treatment (favicon ring/title dimming) and hides the old emoji indicator.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-23T12:18:24Z

+
+    // Save history
+    try {
+      const { ipcRenderer } = require("electron");
+      const webContentsId = webview.getWebContentsId();
+      tab.savedNavigation = ipcRenderer.sendSync('get-tab-navigation', webContentsId);
+    } catch (e) {
+      console.warn("Failed to save nav history for sleeping tab", e);
+    }
+
+    // Destroy webview
+    webview.remove();
+    this.webviews.delete(tabId);
+
+    // Unregister extension cleanly
+    try {
+      const { ipcRenderer } = require("electron");
+      ipcRenderer.invoke('extensions-unregister-webview', webview.getWebContentsId()).catch(() => {});
+    } catch (e) {}


suspendTab() removes the webview from the DOM before invoking extensions-unregister-webview using webview.getWebContentsId(). Depending on Electron/webview lifecycle timing, this can throw or return an invalid ID, leaving the extension system registered for a destroyed view. Capture webContentsId once before removing the webview and reuse it for both navigation save + unregister.

Suggested change

// Save history

try {

const { ipcRenderer } = require("electron");

const webContentsId = webview.getWebContentsId();

tab.savedNavigation = ipcRenderer.sendSync('get-tab-navigation', webContentsId);

} catch (e) {

console.warn("Failed to save nav history for sleeping tab", e);

}

// Destroy webview

webview.remove();

this.webviews.delete(tabId);

// Unregister extension cleanly

try {

const { ipcRenderer } = require("electron");

ipcRenderer.invoke('extensions-unregister-webview', webview.getWebContentsId()).catch(() => {});

} catch (e) {}

// Capture webContentsId once while the webview is still alive

let webContentsId = null;

try {

webContentsId = webview.getWebContentsId();

} catch (e) {

console.warn("Failed to get webContentsId for sleeping tab", e);

}

// Save history

if (webContentsId != null) {

try {

const { ipcRenderer } = require("electron");

tab.savedNavigation = ipcRenderer.sendSync('get-tab-navigation', webContentsId);

} catch (e) {

console.warn("Failed to save nav history for sleeping tab", e);

}

}

// Destroy webview

webview.remove();

this.webviews.delete(tabId);

// Unregister extension cleanly

if (webContentsId != null) {

try {

const { ipcRenderer } = require("electron");

ipcRenderer

.invoke('extensions-unregister-webview', webContentsId)

.catch(err => {

console.warn("Failed to unregister webview extensions for sleeping tab", err);

});

} catch (e) {

console.warn("Error while requesting webview extension unregister for sleeping tab", e);

}

}

Is this comment addressed?

addressed in fc0187e

…related UI elements

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 9 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…gation handling

…prove tab suspension logic

akhileshthite

Good start!
I have comments related benchmark details, navigation concerns, and UI suggestions.

akhileshthite · 2026-03-27T18:27:01Z

I just realized that we don't have Tabs.md in docs/, IIRC @Ankesh2004 was working on it when he originally shipped tabs.

@Ayush-Vish It would be good to include memory saver there.

…into feature/memory-saver

…peersky-browser into feature/memory-saver

akhileshthite

Mostly related to Doc, UI, and a missing unaddressed comment.

akhileshthite · 2026-04-10T23:07:12Z

+---
+
+## 6. Memory Saver
+


Display SS, save as ./docs/images/peersky-memory-saver.png. Keep width width="800".

We need visuals of 10 cropped open tabs. Before and After benchmark graph. As I mentioned in the linked comment, we can also compare Chrome's memory saver performance with ours in a graph.

(#165)

akhileshthite · 2026-04-10T23:51:42Z

+
+    // Save history
+    try {
+      const { ipcRenderer } = require("electron");
+      const webContentsId = webview.getWebContentsId();
+      tab.savedNavigation = ipcRenderer.sendSync('get-tab-navigation', webContentsId);
+    } catch (e) {
+      console.warn("Failed to save nav history for sleeping tab", e);
+    }
+
+    // Destroy webview
+    webview.remove();
+    this.webviews.delete(tabId);
+
+    // Unregister extension cleanly
+    try {
+      const { ipcRenderer } = require("electron");
+      ipcRenderer.invoke('extensions-unregister-webview', webview.getWebContentsId()).catch(() => {});
+    } catch (e) {}


Is this comment addressed?

…te idle threshold to 30 minutes

akhileshthite

Amazing!
We're almost there :D

…improve UI visibility

Ayush-Vish added 2 commits March 23, 2026 17:10

feat(settings): add Memory Saver feature with exclusions management

44f269b

feat(settings): update Memory Saver feature with improved UI and excl…

e8a6b82

…usion management

Copilot AI review requested due to automatic review settings March 23, 2026 12:13

Copilot started reviewing on behalf of Ayush-Vish March 23, 2026 12:14 View session

Ayush-Vish changed the title ~~feat: implement peersky://settings/performance to free up the inactive tabs~~ feat(performance): Add Memory Saver with tab suspension and exclusion list Mar 23, 2026

Copilot AI reviewed Mar 23, 2026

View reviewed changes

feat(settings): extend Memory Saver timeout to 30 minutes and update …

e61621a

…related UI elements

Ayush-Vish requested a review from Copilot March 23, 2026 12:31

Copilot started reviewing on behalf of Ayush-Vish March 23, 2026 12:32 View session

Copilot AI reviewed Mar 23, 2026

View reviewed changes

Ayush-Vish added 3 commits March 23, 2026 23:28

feat(memory-saver): improve Memory Saver cleanup and enhance tab navi…

8e1d0bc

…gation handling

feat(memory-saver): add IPC handler for webContents audibility and im…

c970117

…prove tab suspension logic

feat(memory-saver): revert back to old interval.

7afb866

akhileshthite changed the title ~~feat(performance): Add Memory Saver with tab suspension and exclusion list~~ perf: add Memory Saver with tab suspension and exclusion list Mar 23, 2026

akhileshthite assigned Ayush-Vish Mar 23, 2026

akhileshthite added enhancement New feature or request electron Related to electron.js labels Mar 23, 2026

akhileshthite requested changes Mar 27, 2026

View reviewed changes

Comment thread src/pages/tab-bar.js

Comment thread src/pages/tab-bar.js

Comment thread src/pages/settings.html Outdated

akhileshthite and others added 8 commits April 2, 2026 11:05

Merge branch 'main' into feature/memory-saver

a288832

Merge branch 'main' of https://github.com/p2plabsxyz/peersky-browser …

41a8b5d

…into feature/memory-saver

docs: added tabs.md

9f652a8

fix: fixed history deletion for suspended tabs

756645e

Merge branch 'main' of https://github.com/p2plabsxyz/peersky-browser …

dff141a

…into feature/memory-saver

Merge branch 'feature/memory-saver' of https://github.com/Ayush-Vish/…

02c0c25

…peersky-browser into feature/memory-saver

feat: added performance section in tabs section in settings

3b5bf10

fix: change the idle threshold to 30 minute

a5a5d5b

akhileshthite requested changes Apr 11, 2026

View reviewed changes

Ayush-Vish added 2 commits April 15, 2026 00:24

docs: updated tabs.md

cb7daec

fix: improve webview extension unregistering

fc0187e

Ayush-Vish added 3 commits April 15, 2026 01:43

feat: enhance Memory Saver documentation with benchmark data and upda…

8767f82

…te idle threshold to 30 minutes

Refactor code structure for improved readability and maintainability

a41ad92

docs: added benchmarks image.

b93599f

akhileshthite requested changes Apr 15, 2026

View reviewed changes

Comment thread docs/Tabs.md Outdated

Comment thread src/settings-manager.js Outdated

Comment thread src/pages/tab-bar.js Outdated

Comment thread src/pages/static/js/settings.js Outdated

Comment thread src/pages/settings.html

akhileshthite mentioned this pull request Apr 15, 2026

feat: Native Split View (Tab Tiling) Support #182

Open

10 tasks

feat: update Memory Saver settings to include default exclusions and …

4beceae

…improve UI visibility

Conversation

Ayush-Vish commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related Issue (if any)

Describe the add-ons or changes you've made

Type of change

How Has This Been Tested?

Checklist:

Screenshots (Only for Front End and UI/UX Designers)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

akhileshthite Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Ayush-Vish Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

akhileshthite left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

akhileshthite commented Mar 27, 2026

Uh oh!

akhileshthite left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

akhileshthite Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

akhileshthite Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

akhileshthite Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

akhileshthite left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Ayush-Vish commented Mar 23, 2026 •

edited

Loading