Features/add-remote-reference-support #1
Conversation
p1-ra
force-pushed
the
features/add-remote-reference-support
branch
2 times, most recently
from
1b29991 to
0eb0fc0
Compare
p1-ra
force-pushed
the
features/add-remote-reference-support
branch
2 times, most recently
from
0829d7f to
4d1804d
Compare
p1-ra
force-pushed
the
features/add-remote-reference-support
branch
from
4d1804d to
33276c9
Compare
p1-ra
force-pushed
the
features/add-remote-reference-support
branch
from
1cb0ddb to
1805b0d
Compare
p1-ra
left a comment
p1-ra
left a comment
There was a problem hiding this comment.
You can try to parse https://raw.githubusercontent.com/jdegre/5GC_APIs/master/TS29504_Nudr_DataRepository.yaml
It ~succeed before that I made some breaking changes on other part of code. To see if there the change broke the ResolvedScehama or not:
- Finally document was not a valid oai one due to the final merge (
#/components/securitySchemes) was incorrect - There was one external reference that failed to be resolved
| from .pointer import Pointer | ||
|
|
||
|
|
||
| class Reference: |
There was a problem hiding this comment.
I made some refactoring on the Reference object, that as has been quickly integrated to the ResolvedSchema, but not tested, there is maybe some thing to fix there
| def _process(self) -> None: | ||
| self._process_remote_paths() | ||
| self._process_remote_components(self._root) | ||
| self._root.update(self._resolved_remotes_components) |
There was a problem hiding this comment.
The merge here is too wild, it need fixe. I was doing my test on: https://raw.githubusercontent.com/jdegre/5GC_APIs/master/TS29504_Nudr_DataRepository.yaml
It's #components/securitySchemes was erased by the ones of _resolved_remotes_components, leading to an invalid document. Also potentially some naming collision to handle regarding the resolved remote reference and the existing one on the root schema
| return | ||
| else: | ||
| pass | ||
| # print('=' * 120) |
There was a problem hiding this comment.
Here we have a collision to handle, we have two remote components with the same name but different content, may be implemented later, but definitly required
There was a problem hiding this comment.
Also, we should probably extract the code responsible to detect collisions into its own class, thus later on we could customise collision detection with DI.
Assigned new reference name should also be handle there (Same goal, for easy behaviour customization)
| class ResolvedSchema: | ||
| def __init__(self, root: SchemaData, refs: Dict[str, SchemaData], errors: List[str]): | ||
| self._root: SchemaData = root | ||
| self._refs: Dict[str, SchemaData] = refs |
There was a problem hiding this comment.
In last refactor, the keys of refenrences dict changed from:
./TSXXXX, to /absolute/path/to/TSXXX, in order to avoid the case where two external ref have a same relative reference to them pointing to two different files.
It may need some fix in ResolvedSchema class, not tested, not sure if that change introduced behaviour change or not
TBD