fix(estree/ast): fix IdentifierName and IdentifierReference

crates/oxc_ast/src/ast/js.rs

@@ -209,7 +209,10 @@ pub use match_expression;
 #[ast(visit)]
 #[derive(Debug, Clone)]
 #[generate_derive(CloneIn, GetSpan, GetSpanMut, ContentEq, ESTree)]
-#[estree(rename = "Identifier")]
+#[estree(
+    rename = "Identifier",
+    add_fields(decorators = TsEmptyArray, optional = TsFalse, typeAnnotation = TsNull)
+)]
 pub struct IdentifierName<'a> {
     pub span: Span,
     #[estree(json_safe)]
@@ -224,7 +227,10 @@ pub struct IdentifierName<'a> {
 #[ast(visit)]
 #[derive(Debug, Clone)]
 #[generate_derive(CloneIn, GetSpan, GetSpanMut, ContentEq, ESTree)]
-#[estree(rename = "Identifier")]
+#[estree(
+    rename = "Identifier",
+    add_fields(decorators = TsEmptyArray, optional = TsFalse, typeAnnotation = TsNull)
+)]
 pub struct IdentifierReference<'a> {
     pub span: Span,
     /// The name of the identifier being referenced.

crates/oxc_ast/src/generated/derive_estree.rs

@@ -87,6 +87,9 @@ impl ESTree for IdentifierName<'_> {
         state.serialize_field("start", &self.span.start);
         state.serialize_field("end", &self.span.end);
         state.serialize_field("name", &JsonSafeString(self.name.as_str()));
+        state.serialize_ts_field("decorators", &crate::serialize::TsEmptyArray(self));
+        state.serialize_ts_field("optional", &crate::serialize::TsFalse(self));
+        state.serialize_ts_field("typeAnnotation", &crate::serialize::TsNull(self));
         state.end();
     }
 }
@@ -98,6 +101,9 @@ impl ESTree for IdentifierReference<'_> {
         state.serialize_field("start", &self.span.start);
         state.serialize_field("end", &self.span.end);
         state.serialize_field("name", &JsonSafeString(self.name.as_str()));
+        state.serialize_ts_field("decorators", &crate::serialize::TsEmptyArray(self));
+        state.serialize_ts_field("optional", &crate::serialize::TsFalse(self));
+        state.serialize_ts_field("typeAnnotation", &crate::serialize::TsNull(self));
         state.end();
     }
 }

crates/oxc_ast/src/serialize.rs

@@ -84,6 +84,17 @@ impl<T> ESTree for Null<'_, T> {
     }
 }
 
+#[ast_meta]
+#[estree(ts_type = "null", raw_deser = "null")]
+#[ts]
+pub struct TsNull<'b, T>(#[expect(dead_code)] pub &'b T);
+
+impl<T> ESTree for TsNull<'_, T> {
+    fn serialize<S: Serializer>(&self, serializer: S) {
+        ().serialize(serializer);
+    }
+}
+
 /// Serialized as `true`.
 #[ast_meta]
 #[estree(ts_type = "true", raw_deser = "true")]
@@ -106,6 +117,17 @@ impl<T> ESTree for False<'_, T> {
     }
 }
 
+#[ast_meta]
+#[estree(ts_type = "false", raw_deser = "false")]
+#[ts]
+pub struct TsFalse<'b, T>(#[expect(dead_code)] pub &'b T);
+
+impl<T> ESTree for TsFalse<'_, T> {
+    fn serialize<S: Serializer>(&self, serializer: S) {
+        false.serialize(serializer);
+    }
+}
+
 /// Serialized as `"in"`.
 #[ast_meta]
 #[estree(ts_type = "'in'", raw_deser = "'in'")]
@@ -128,6 +150,17 @@ impl<T> ESTree for Init<'_, T> {
     }
 }
 
+#[ast_meta]
+#[estree(ts_type = "[]", raw_deser = "[]")]
+#[ts]
+pub struct TsEmptyArray<'b, T>(#[expect(dead_code)] pub &'b T);
+
+impl<T> ESTree for TsEmptyArray<'_, T> {
+    fn serialize<S: Serializer>(&self, serializer: S) {
+        [(); 0].serialize(serializer);
+    }
+}
+
 // --------------------
 // Literals
 // --------------------
@@ -538,6 +571,9 @@ impl ESTree for ClassImplements<'_, '_> {
     raw_deser = "
         const ident = DESER[Box<IdentifierReference>](POS);
         ident.type = 'JSXIdentifier';
+        delete ident.decorators;
+        delete ident.optional;
+        delete ident.typeAnnotation;
         ident
     "
 )]

napi/parser/deserialize-js.js

@@ -3362,6 +3362,9 @@ function deserializeJSXElementName(pos) {
     case 1:
       const ident = deserializeBoxIdentifierReference(pos + 8);
       ident.type = 'JSXIdentifier';
+      delete ident.decorators;
+      delete ident.optional;
+      delete ident.typeAnnotation;
       return ident;
     case 2:
       return deserializeBoxJSXNamespacedName(pos + 8);
@@ -3380,6 +3383,9 @@ function deserializeJSXMemberExpressionObject(pos) {
     case 0:
       const ident = deserializeBoxIdentifierReference(pos + 8);
       ident.type = 'JSXIdentifier';
+      delete ident.decorators;
+      delete ident.optional;
+      delete ident.typeAnnotation;
       return ident;
     case 1:
       return deserializeBoxJSXMemberExpression(pos + 8);

napi/parser/deserialize-ts.js

@@ -53,6 +53,9 @@ function deserializeIdentifierName(pos) {
     start: deserializeU32(pos),
     end: deserializeU32(pos + 4),
     name: deserializeStr(pos + 8),
+    decorators: [],
+    optional: false,
+    typeAnnotation: null,
   };
 }
 
@@ -62,6 +65,9 @@ function deserializeIdentifierReference(pos) {
     start: deserializeU32(pos),
     end: deserializeU32(pos + 4),
     name: deserializeStr(pos + 8),
+    decorators: [],
+    optional: false,
+    typeAnnotation: null,
   };
 }
 
@@ -3417,6 +3423,9 @@ function deserializeJSXElementName(pos) {
     case 1:
       const ident = deserializeBoxIdentifierReference(pos + 8);
       ident.type = 'JSXIdentifier';
+      delete ident.decorators;
+      delete ident.optional;
+      delete ident.typeAnnotation;
       return ident;
     case 2:
       return deserializeBoxJSXNamespacedName(pos + 8);
@@ -3435,6 +3444,9 @@ function deserializeJSXMemberExpressionObject(pos) {
     case 0:
       const ident = deserializeBoxIdentifierReference(pos + 8);
       ident.type = 'JSXIdentifier';
+      delete ident.decorators;
+      delete ident.optional;
+      delete ident.typeAnnotation;
       return ident;
     case 1:
       return deserializeBoxJSXMemberExpression(pos + 8);

npm/oxc-types/types.d.ts

@@ -54,11 +54,17 @@ export type Expression =
 export interface IdentifierName extends Span {
   type: 'Identifier';
   name: string;
+  decorators?: [];
+  optional?: false;
+  typeAnnotation?: null;
 }
 
 export interface IdentifierReference extends Span {
   type: 'Identifier';
   name: string;
+  decorators?: [];
+  optional?: false;
+  typeAnnotation?: null;
 }
 
 export interface BindingIdentifier extends Span {