refactor(minifier): remove duplicated typeof comparison to non-strict equality compression#9010
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 10, 2025
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Feb 10, 2025
github-actions
bot
added
A-minifier
CodSpeed Performance ReportMerging #9010 will not alter performanceComparing Summary
|
sapphi-red
changed the base branch from
02-10-refactor_minifier_move_equality_comparison_to_constantevaluation
to
graphite-base/9010
sapphi-red
force-pushed
the
graphite-base/9010
branch
from
8f8a3c9 to
2d3dd93
Compare
sapphi-red
force-pushed
the
02-10-refactor_minifier_remove_duplicated_typeof_comparison_to_non-strict_equality_compression
branch
from
39413d6 to
ab6d6a0
Compare
Member
Merge activity
|
…ct equality compression (#9010) This is handled by `try_minimize_binary`. https://github.com/oxc-project/oxc/blob/c2ca7a70a4b07f253de63b8220258d90e9fe0f38/crates/oxc_minifier/src/peephole/minimize_conditions.rs#L109
graphite-app
bot
force-pushed
the
02-10-refactor_minifier_remove_duplicated_typeof_comparison_to_non-strict_equality_compression
branch
from
ab6d6a0 to
9193217
Compare
graphite-app
bot
deleted the
02-10-refactor_minifier_remove_duplicated_typeof_comparison_to_non-strict_equality_compression
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is handled by
try_minimize_binary.https://github.com/oxc-project/oxc/blob/c2ca7a70a4b07f253de63b8220258d90e9fe0f38/crates/oxc_minifier/src/peephole/minimize_conditions.rs#L109