refactor(ast): support #[estree(ts_alias)] attr on enums and use it on RegExpPattern and RegExpFlags#8953
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 9, 2025
Conversation
github-actions
bot
added
A-ast
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #8953 will not alter performanceComparing Summary
|
hi-ogawa
approved these changes
Feb 9, 2025
Member
Author
Merge activity
|
… on `RegExpPattern` and `RegExpFlags` (#8953) It's preferable to specify how a type is serialized and its TS type on the type itself, rather than on fields containing that type. Support the `#[estree(ts_alias = "...")]` attr on enums (previously was only supported on structs). Use that attr on `RegExpPattern` and `RegExpFlags`.
graphite-app
bot
force-pushed
the
02-07-refactor_ast_support_estree_ts_alias_attr_on_enums_and_use_it_on_regexppattern_and_regexpflags_
branch
from
646ffee to
a1ca2eb
Compare
graphite-app
bot
deleted the
02-07-refactor_ast_support_estree_ts_alias_attr_on_enums_and_use_it_on_regexppattern_and_regexpflags_
branch
Dunqing
pushed a commit
that referenced
this pull request
Feb 10, 2025
… on `RegExpPattern` and `RegExpFlags` (#8953) It's preferable to specify how a type is serialized and its TS type on the type itself, rather than on fields containing that type. Support the `#[estree(ts_alias = "...")]` attr on enums (previously was only supported on structs). Use that attr on `RegExpPattern` and `RegExpFlags`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's preferable to specify how a type is serialized and its TS type on the type itself, rather than on fields containing that type. Support the
#[estree(ts_alias = "...")]attr on enums (previously was only supported on structs). Use that attr onRegExpPatternandRegExpFlags.