Skip to content

ci(build): run cargo check on MSRV#8932

Closed
overlookmotel wants to merge 1 commit intomainfrom
02-06-ci_build_run_cargo_check_on_msrv
Closed

ci(build): run cargo check on MSRV#8932
overlookmotel wants to merge 1 commit intomainfrom
02-06-ci_build_run_cargo_check_on_msrv

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Feb 6, 2025

Run cargo check in CI on our MSRV. This should avoid problems like #8913.

Copy link
Member Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review February 6, 2025 19:36
@overlookmotel overlookmotel force-pushed the 02-06-ci_build_run_cargo_check_on_msrv branch from 8c3adab to 83f85f7 Compare February 6, 2025 19:43
@overlookmotel overlookmotel marked this pull request as draft February 6, 2025 19:49
@overlookmotel
Copy link
Member Author

It doesn't work. It should be failing, because #8929 hasn't been merged yet. On my local machine, cargo ck fails on Rust 1.81.0 on this branch.

Any idea @Boshen? Or shall we just forget about it?

@overlookmotel overlookmotel changed the base branch from 02-06-chore_build_bump_msrv_to_1.81.0 to graphite-base/8932 February 7, 2025 11:12
@overlookmotel overlookmotel force-pushed the 02-06-ci_build_run_cargo_check_on_msrv branch from 83f85f7 to 964925b Compare February 7, 2025 11:13
@Boshen Boshen force-pushed the graphite-base/8932 branch from 53b43ba to 94b8d29 Compare February 7, 2025 15:11
@Boshen Boshen force-pushed the 02-06-ci_build_run_cargo_check_on_msrv branch from 964925b to f2ca0a8 Compare February 7, 2025 15:11
@Boshen Boshen changed the base branch from graphite-base/8932 to main February 7, 2025 15:12
@Boshen Boshen force-pushed the 02-06-ci_build_run_cargo_check_on_msrv branch from f2ca0a8 to 70e0923 Compare February 7, 2025 15:12
@Boshen Boshen closed this Feb 8, 2025
@Boshen Boshen deleted the 02-06-ci_build_run_cargo_check_on_msrv branch February 8, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants