Skip to content

refactor(ast): shorten generated code for GetSpan#8883

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-03-refactor_ast_shorten_generated_code_for_getspan_
Feb 4, 2025
Merged

refactor(ast): shorten generated code for GetSpan#8883
graphite-app[bot] merged 1 commit intomainfrom
02-03-refactor_ast_shorten_generated_code_for_getspan_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Feb 3, 2025

Shorten generated code for GetSpan, and simplify the generator a little in the process.

Copy link
Member Author

overlookmotel commented Feb 3, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review February 3, 2025 20:28
@github-actions github-actions bot added A-ast Area - AST A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Feb 3, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 3, 2025

CodSpeed Performance Report

Merging #8883 will not alter performance

Comparing 02-03-refactor_ast_shorten_generated_code_for_getspan_ (5f5188c) with main (f4662a9)

Summary

✅ 33 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 02-03-feat_ast_improve_ts_type_definitions_for_appended_fields branch from ee40942 to f0ea8d6 Compare February 3, 2025 22:01
@overlookmotel overlookmotel force-pushed the 02-03-refactor_ast_shorten_generated_code_for_getspan_ branch from 2c15fd8 to 6026e7f Compare February 3, 2025 22:01
@overlookmotel overlookmotel force-pushed the 02-03-feat_ast_improve_ts_type_definitions_for_appended_fields branch from f0ea8d6 to 9b10ee8 Compare February 4, 2025 09:26
@overlookmotel overlookmotel force-pushed the 02-03-refactor_ast_shorten_generated_code_for_getspan_ branch from 6026e7f to 2b2b68b Compare February 4, 2025 09:26
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 4, 2025

Merge activity

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 4, 2025

Merge activity

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 4, 2025
@graphite-app graphite-app bot changed the base branch from graphite-base/8883 to main February 4, 2025 22:30
Shorten generated code for `GetSpan`, and simplify the generator a little in the process.
@graphite-app graphite-app bot force-pushed the 02-03-refactor_ast_shorten_generated_code_for_getspan_ branch from f055d92 to 5f5188c Compare February 4, 2025 22:31
@graphite-app graphite-app bot merged commit 5f5188c into main Feb 4, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 02-03-refactor_ast_shorten_generated_code_for_getspan_ branch February 4, 2025 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant