feat(minifier): merge similar if stmts

[camc314]

No description provided.

[camc314]

• feat(minifier): merge similar if stmts #8509 : 2 dependent PRs (#8514 , #8517 ) 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #8509 will degrade performances by 33.75%

_{Comparing c/01-15-feat_minifier_merge_similar_if_stmts (62a3dac) with main (7e61b23)}

Summary

❌ 1 regressions
✅ 31 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	main	c/01-15-feat_minifier_merge_similar_if_stmts	Change
❌	minifier[typescript.js]	332 ms	501.1 ms	-33.75%

[Boshen]

-33.76%

this is not good.

[camc314]

hmm most of the perf impact is via using ContentEq to compare the content of the if alternate/consequent

[camc314]

Perhaps we could being back ContentHash to avoid having to re-hash if stmts consequents on each iteration of the loop?

[Boshen]

I'm going to revamp the whole thing so that changes like this won't introduce performance regressions.