Skip to content

refactor(ast): AstBuilder extra methods use SPAN#7769

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-10-refactor_ast_astbuilder_extra_methods_use_span_
Dec 10, 2024
Merged

refactor(ast): AstBuilder extra methods use SPAN#7769
graphite-app[bot] merged 1 commit intomainfrom
12-10-refactor_ast_astbuilder_extra_methods_use_span_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Dec 10, 2024

Pure refactor. SPAN is shorter than Span::default() and is what we use elsewhere.

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 10, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

overlookmotel commented Dec 10, 2024

@github-actions github-actions bot added A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 10, 2024
@overlookmotel overlookmotel marked this pull request as ready for review December 10, 2024 13:09
@overlookmotel
Copy link
Member Author

Trivial refactor, so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Dec 10, 2024
Copy link
Member Author

overlookmotel commented Dec 10, 2024

Merge activity

  • Dec 10, 8:10 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 10, 8:10 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 10, 8:15 AM EST: A user merged this pull request with the Graphite merge queue.

Pure refactor. `SPAN` is shorter than `Span::default()` and is what we use elsewhere.
@overlookmotel overlookmotel force-pushed the 12-10-refactor_ast_astbuilder_extra_methods_use_span_ branch from ecdf495 to 98afe65 Compare December 10, 2024 13:11
@graphite-app graphite-app bot merged commit 98afe65 into main Dec 10, 2024
@graphite-app graphite-app bot deleted the 12-10-refactor_ast_astbuilder_extra_methods_use_span_ branch December 10, 2024 13:15
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 10, 2024

CodSpeed Performance Report

Merging #7769 will not alter performance

Comparing 12-10-refactor_ast_astbuilder_extra_methods_use_span_ (98afe65) with main (f3cfa7f)

Summary

✅ 29 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant