Skip to content

refactor(transformer/class-properties): shorten code#7700

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-06-refactor_transformer_class-properties_shorten_code
Dec 6, 2024
Merged

refactor(transformer/class-properties): shorten code#7700
graphite-app[bot] merged 1 commit intomainfrom
12-06-refactor_transformer_class-properties_shorten_code

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Dec 6, 2024

Follow-on after #7697. No need to cast twice. You can go from MemberExpression direct to AssignmentTarget.

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 6, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 6, 2024
Copy link
Member Author

overlookmotel commented Dec 6, 2024

@overlookmotel overlookmotel marked this pull request as ready for review December 6, 2024 14:32
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 6, 2024

CodSpeed Performance Report

Merging #7700 will not alter performance

Comparing 12-06-refactor_transformer_class-properties_shorten_code (e67e981) with main (ab3e1c3)

Summary

✅ 29 untouched benchmarks

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 6, 2024

Merge activity

Follow-on after #7697. No need to cast twice. You can go from `MemberExpression` direct to `AssignmentTarget`.
@Dunqing Dunqing force-pushed the 12-06-refactor_transformer_class-properties_shorten_code branch from 7519d6a to e67e981 Compare December 6, 2024 15:15
@graphite-app graphite-app bot merged commit e67e981 into main Dec 6, 2024
@graphite-app graphite-app bot deleted the 12-06-refactor_transformer_class-properties_shorten_code branch December 6, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant