Skip to content

refactor(ast): rename vars#7658

Merged
overlookmotel merged 1 commit intomainfrom
12-05-refactor_ast_rename_vars
Dec 5, 2024
Merged

refactor(ast): rename vars#7658
overlookmotel merged 1 commit intomainfrom
12-05-refactor_ast_rename_vars

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Dec 5, 2024

Pure refactor. Rename vars in serialization code. value.value is a bit confusing.

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 5, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 5, 2024
@overlookmotel overlookmotel marked this pull request as ready for review December 5, 2024 00:39
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 5, 2024

CodSpeed Performance Report

Merging #7658 will not alter performance

Comparing 12-05-refactor_ast_rename_vars (746c8aa) with main (ad76d1d)

Summary

✅ 29 untouched benchmarks

@overlookmotel
Copy link
Member Author

Trivial change, so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Dec 5, 2024
Copy link
Member Author

overlookmotel commented Dec 5, 2024

Merge activity

  • Dec 4, 7:53 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 4, 7:53 PM EST: A user added this pull request to the Graphite merge queue.
  • Dec 4, 8:00 PM EST: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.
  • Dec 4, 8:01 PM EST: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • Dec 4, 8:09 PM EST: A user added this pull request to the Graphite merge queue.
  • Dec 4, 8:21 PM EST: A user merged this pull request with the Graphite merge queue.

@overlookmotel overlookmotel changed the base branch from 12-05-style_ast_import_atom_ to graphite-base/7658 December 5, 2024 00:53
@graphite-app graphite-app bot changed the base branch from graphite-base/7658 to main December 5, 2024 00:59
@graphite-app graphite-app bot added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels Dec 5, 2024
@overlookmotel overlookmotel force-pushed the 12-05-refactor_ast_rename_vars branch from 0d1aafc to 8ff227d Compare December 5, 2024 01:01
Pure refactor. Rename vars in serialization code. `value.value` is a bit confusing.
@overlookmotel overlookmotel force-pushed the 12-05-refactor_ast_rename_vars branch from 8ff227d to 746c8aa Compare December 5, 2024 01:16
@overlookmotel overlookmotel merged commit 746c8aa into main Dec 5, 2024
@overlookmotel overlookmotel deleted the 12-05-refactor_ast_rename_vars branch December 5, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant