Skip to content

perf(transformer/class-properties): replace recursion with loop #7652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Dec 5, 2024
Merged

perf(transformer/class-properties): replace recursion with loop #7652

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 28 additions & 13 deletions crates/oxc_transformer/src/es2022/class_properties/private.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1216,20 +1216,35 @@ impl<'a, 'ctx> ClassProperties<'a, 'ctx> {
/// Recursively check if the expression has optional expression.
#[inline]
fn has_optional_expression(expr: &Expression<'a>) -> bool {
match expr {
Expression::CallExpression(call) => {
call.optional || Self::has_optional_expression(call.callee.get_inner_expression())
}
Expression::StaticMemberExpression(member) => {
member.optional || Self::has_optional_expression(&member.object)
}
Expression::ComputedMemberExpression(member) => {
member.optional || Self::has_optional_expression(&member.object)
}
Expression::PrivateFieldExpression(member) => {
member.optional || Self::has_optional_expression(&member.object)
let mut expr = expr;
loop {
match expr {
Expression::CallExpression(call) => {
if call.optional {
return true;
}
expr = call.callee.get_inner_expression();
}
Expression::StaticMemberExpression(member) => {
if member.optional {
return true;
}
expr = &member.object;
}
Expression::ComputedMemberExpression(member) => {
if member.optional {
return true;
}
expr = &member.object;
}
Expression::PrivateFieldExpression(member) => {
if member.optional {
return true;
}
expr = &member.object;
}
_ => return false,
}
_ => false,
}
}

Expand Down