Skip to content

feat(linter): report identical logical expressions in const-comparisons#7630

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/12-03-feat_linter_report_identical_logical_expressions_in_const-comparisons
Dec 4, 2024
Merged

feat(linter): report identical logical expressions in const-comparisons#7630
graphite-app[bot] merged 1 commit intomainfrom
c/12-03-feat_linter_report_identical_logical_expressions_in_const-comparisons

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Dec 3, 2024

No description provided.

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 3, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@camc314 camc314 marked this pull request as ready for review December 3, 2024 23:36
Copy link
Contributor Author

camc314 commented Dec 3, 2024

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 3, 2024

CodSpeed Performance Report

Merging #7630 will not alter performance

Comparing c/12-03-feat_linter_report_identical_logical_expressions_in_const-comparisons (a14e76a) with main (afe1e9b)

Summary

✅ 29 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Dec 4, 2024
Copy link
Member

Boshen commented Dec 4, 2024

Merge activity

  • Dec 3, 8:59 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 3, 8:59 PM EST: A user added this pull request to the Graphite merge queue.
  • Dec 3, 9:25 PM EST: The Graphite merge queue removed this pull request due to downstack failures on PR #7627.
  • Dec 3, 9:26 PM EST: A user removed this pull request from the Graphite merge queue.
  • Dec 3, 10:56 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 3, 10:56 PM EST: A user added this pull request to the Graphite merge queue.
  • Dec 3, 10:57 PM EST: A user merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the c/12-03-feat_linter_enhance_const-comparisons_for_more_cases branch from e0caeea to 1ebc96c Compare December 4, 2024 02:06
@Boshen Boshen force-pushed the c/12-03-feat_linter_report_identical_logical_expressions_in_const-comparisons branch from e7096da to ad65069 Compare December 4, 2024 02:07
@Boshen Boshen force-pushed the c/12-03-feat_linter_enhance_const-comparisons_for_more_cases branch from 1ebc96c to 052ff9b Compare December 4, 2024 02:09
@Boshen Boshen force-pushed the c/12-03-feat_linter_report_identical_logical_expressions_in_const-comparisons branch from ad65069 to fe05fff Compare December 4, 2024 02:09
@Boshen Boshen force-pushed the c/12-03-feat_linter_enhance_const-comparisons_for_more_cases branch from 052ff9b to 66e243e Compare December 4, 2024 02:17
@Boshen Boshen force-pushed the c/12-03-feat_linter_report_identical_logical_expressions_in_const-comparisons branch from fe05fff to 2f5c693 Compare December 4, 2024 02:17
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 4, 2024
@Boshen Boshen changed the base branch from c/12-03-feat_linter_enhance_const-comparisons_for_more_cases to graphite-base/7630 December 4, 2024 03:00
@Boshen Boshen force-pushed the graphite-base/7630 branch from 66e243e to afe1e9b Compare December 4, 2024 03:09
@Boshen Boshen force-pushed the c/12-03-feat_linter_report_identical_logical_expressions_in_const-comparisons branch from 2f5c693 to aac1c30 Compare December 4, 2024 03:09
@Boshen Boshen changed the base branch from graphite-base/7630 to main December 4, 2024 03:10
@Boshen Boshen force-pushed the c/12-03-feat_linter_report_identical_logical_expressions_in_const-comparisons branch from aac1c30 to a14e76a Compare December 4, 2024 03:10
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Dec 4, 2024
@graphite-app graphite-app bot merged commit a14e76a into main Dec 4, 2024
@graphite-app graphite-app bot deleted the c/12-03-feat_linter_report_identical_logical_expressions_in_const-comparisons branch December 4, 2024 03:57
@oxc-bot oxc-bot mentioned this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-linter Area - Linter C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants