Skip to content

fix(linter): fix false positives in rules-of-hooks#7606

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/12-03-fix_linter_fix_false_positives_in_rules-of-hooks
Dec 3, 2024
Merged

fix(linter): fix false positives in rules-of-hooks#7606
graphite-app[bot] merged 1 commit intomainfrom
c/12-03-fix_linter_fix_false_positives_in_rules-of-hooks

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Dec 3, 2024

closes #7572

should remove all false positives from this rule

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 3, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

camc314 commented Dec 3, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 requested a review from Boshen December 3, 2024 12:05
@camc314 camc314 force-pushed the c/12-03-fix_linter_fix_false_positives_in_rules-of-hooks branch from 0cb45f8 to 7a2d4f1 Compare December 3, 2024 12:06
@camc314 camc314 marked this pull request as ready for review December 3, 2024 12:07
@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Dec 3, 2024
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Dec 3, 2024
Copy link
Member

Boshen commented Dec 3, 2024

Merge activity

  • Dec 3, 7:16 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 3, 7:16 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 3, 7:27 AM EST: A user merged this pull request with the Graphite merge queue.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 3, 2024

CodSpeed Performance Report

Merging #7606 will not alter performance

Comparing c/12-03-fix_linter_fix_false_positives_in_rules-of-hooks (e80214c) with main (40792b4)

Summary

✅ 29 untouched benchmarks

closes #7572

should remove all false positives from this rule
@Boshen Boshen force-pushed the c/12-03-fix_linter_fix_false_positives_in_rules-of-hooks branch from 7a2d4f1 to e80214c Compare December 3, 2024 12:19
@graphite-app graphite-app bot merged commit e80214c into main Dec 3, 2024
@graphite-app graphite-app bot deleted the c/12-03-fix_linter_fix_false_positives_in_rules-of-hooks branch December 3, 2024 12:27
@oxc-bot oxc-bot mentioned this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(linter) react/rules-of-hooks false positives

2 participants