fix(oxc_transformer): correct generate ThisExpr and import.meta in jsx pragma

[IWANABETHATGUY]

No description provided.

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[IWANABETHATGUY]

• fix(oxc_transformer): correct generate ThisExpr and import.meta in jsx pragma #7553 👈 (View in Graphite)
• feat(oxc_transformer): support jsx pragma that are long member expressions #7538
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #7553 will not alter performance

_{Comparing 11-30-fix_correct_generate_this_expr (6af8659) with main (6dd71c6)}

Summary

✅ 29 untouched benchmarks

[Boshen]

@overlookmotel need your review.

[overlookmotel]

Sorry to say I see problems.

Also, could you please add a test for import.meta?

We can make this more performant by changing Pragma into an enum, to avoid string comparisons on every call to create_expression. Something like:

enum Pragma<'a> {
  /// `createElement`
  Single(Atom<'a>),
  /// `React.createElement`
  Double(Atom<'a>, Atom<'a>),
  /// `foo.bar.qux`
  Many(Vec<Atom<'a>>),
  /// `this`, `this.foo`, `this.foo.bar.qux`
  This(Vec<Atom<'a>>),
  /// `import.meta`, `import.meta.foo`, `import.meta.foo.bar.qux`
  ImportMeta(Vec<Atom<'a>>),
}

In practice, it's going to always be Single or Double. All the others are edge cases.

But we can do that optimization in a follow-up.

[overlookmotel]

Thanks for adding the tests.

I've pushed a couple more commits:

1. Get rid of the Boxes in create_arbitrary_length_member_expr_or_ident. They didn't appear to add anything.
2. Tweak the tests to make them more explicit.

[overlookmotel]

Merge activity

• Dec 3, 8:53 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Dec 3, 8:53 AM EST: A user added this pull request to the Graphite merge queue.
• Dec 3, 8:59 AM EST: A user merged this pull request with the Graphite merge queue.