refactor(linter/plugins): remove dead code#20083
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merge activity
|
There was a problem hiding this comment.
Pull request overview
This PR removes outdated, commented-out code paths related to a prior/abandoned “lazy deserialization” plugin implementation in the oxlint JS plugin runtime, reducing noise and keeping the plugin code aligned with the current traversal approach.
Changes:
- Removed an obsolete commented-out
Visitorinterface draft from the plugin type definitions. - Removed commented-out “lazy implementation” imports and an unused alternate AST-walk block from the linting entrypoint.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/oxlint/src-js/plugins/types.ts | Deletes stale commented-out type definitions for an unused lazy visitor approach. |
| apps/oxlint/src-js/plugins/lint.ts | Deletes stale commented-out lazy-walk imports and an alternate traversal block. |
We had pieces of commented-out code related to an alternative implementation of linter plugins using lazy deserialization. This code is now very out of date, and so largely pointless. Remove it.
90c5dee to
7365886
Compare

We had pieces of commented-out code related to an alternative implementation of linter plugins using lazy deserialization. This code is now very out of date, and so largely pointless. Remove it.