Skip to content

refactor(linter/plugins): remove dead code#20083

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/03-06-refactor_linter_plugins_remove_dead_code
Mar 6, 2026
Merged

refactor(linter/plugins): remove dead code#20083
graphite-app[bot] merged 1 commit intomainfrom
om/03-06-refactor_linter_plugins_remove_dead_code

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Mar 6, 2026

We had pieces of commented-out code related to an alternative implementation of linter plugins using lazy deserialization. This code is now very out of date, and so largely pointless. Remove it.

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI A-linter-plugins Area - Linter JS plugins C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Mar 6, 2026
@overlookmotel overlookmotel marked this pull request as ready for review March 6, 2026 17:45
Copilot AI review requested due to automatic review settings March 6, 2026 17:45
@overlookmotel overlookmotel requested a review from camc314 as a code owner March 6, 2026 17:45
@overlookmotel overlookmotel self-assigned this Mar 6, 2026
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Mar 6, 2026
Copy link
Member Author

overlookmotel commented Mar 6, 2026

Merge activity

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes outdated, commented-out code paths related to a prior/abandoned “lazy deserialization” plugin implementation in the oxlint JS plugin runtime, reducing noise and keeping the plugin code aligned with the current traversal approach.

Changes:

  • Removed an obsolete commented-out Visitor interface draft from the plugin type definitions.
  • Removed commented-out “lazy implementation” imports and an unused alternate AST-walk block from the linting entrypoint.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
apps/oxlint/src-js/plugins/types.ts Deletes stale commented-out type definitions for an unused lazy visitor approach.
apps/oxlint/src-js/plugins/lint.ts Deletes stale commented-out lazy-walk imports and an alternate traversal block.

We had pieces of commented-out code related to an alternative implementation of linter plugins using lazy deserialization. This code is now very out of date, and so largely pointless. Remove it.
@graphite-app graphite-app bot force-pushed the om/03-06-refactor_linter_plugins_remove_dead_code branch from 90c5dee to 7365886 Compare March 6, 2026 17:53
@graphite-app graphite-app bot merged commit 7365886 into main Mar 6, 2026
19 checks passed
@graphite-app graphite-app bot deleted the om/03-06-refactor_linter_plugins_remove_dead_code branch March 6, 2026 18:00
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants