perf(allocator): increase initial chunk size from 512B to 16KB#18234
perf(allocator): increase initial chunk size from 512B to 16KB#18234graphite-app[bot] merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR optimizes memory allocation performance by increasing the initial chunk size from 512 bytes to 16 KB, reducing malloc calls by approximately 30% based on benchmarking against 310K real-world JavaScript/TypeScript files.
Changes:
- Increased
FIRST_ALLOCATION_GOALconstant from 512B (1 << 9) to 16KB (1 << 14) - Updated documentation to explain the rationale with benchmark data
- Fixed
Bump::with_capacity()to use the requested capacity as the starting point
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes
|
d7978f3 to
e6c8c44
Compare
|
Codspeed should not reveal any performance improvements because the allocator is always created outside the benchmark.
|
|
Not seeing any downsides of this change, merging. |
Merge activity
|
## Summary - Increase `FIRST_ALLOCATION_GOAL` from 512 bytes to 16 KB to reduce malloc calls - Fix `Bump::with_capacity()` to respect exact capacity requested (otherwise `with_capacity(1024)` would allocate 16KB) ## Malloc Reduction Tested against 310K real-world JS/TS files: | Dataset | Files | Before (avg mallocs) | After | Reduction | |---------|-------|---------------------|-------|-----------| | oxlint-ecosystem-ci | 256K | 10.99 | 7.72 | **30%** | | monitor-oxc npm | 53K | 11.56 | 8.51 | **26%** | Memory overhead increases by ~37% in allocated capacity, but actual memory *used* remains the same since AST size does not change. ## Parser Benchmark (vs main) | File | Size | Change | |------|------|--------| | RadixUIAdoptionSection.jsx | 2.5 KB | **-5.14%** ✅ | | cal.com.tsx | 1 MB | **-4.85%** ✅ | | react.development.js | 84 KB | -0.19% | | binder.ts | 193 KB | -0.53% | | checker.ts | 2.9 MB | -0.03% | Smaller/medium files show ~5% speedup from fewer malloc calls. 🤖 Generated with [Claude Code](https://claude.ai/code)
e6c8c44 to
2349031
Compare
### 💥 BREAKING CHANGES - 22dec6a semantic: [**BREAKING**] Remove `Scoping::scope_build_child_ids` and all related APIs (#18362) (Dunqing) - 30a4899 oxc: [**BREAKING**] Remove `CompilerInterface::semantic_child_scope_ids` (#18361) (Dunqing) - 777fc40 ast: [**BREAKING**] Add `Ident` type (#18354) (Boshen) - af0ca46 span: [**BREAKING**] Use `ModuleKind::CommonJS` for `SourceType::cjs()` (#18276) (sapphi-red) ### 🚀 Features - 0a02026 semantic: Add TS1499 code to diagnostic (#18557) (camc314) - 8b4618f parser: Add TS1500 code to diagnostic (#18547) (camc314) - 866b6b3 parser: Add TS1048 code to diagnostic (#18546) (camc314) - 1117c44 parser: Add TS1054 code to diagnostic (#18541) (camc314) - e4fcdde semantic: Add TS1053 code to diagnostic (#18539) (camc314) - bcbf396 semantic: Add TS1052 code to diagnostic (#18538) (camc314) - 8155edf semantic: Add TS1049 code to diagnostic (#18535) (camc314) - 51d3b3f parser: Add TS1502 code to diagnostic (#18534) (camc314) - 00854e8 semantic: Add TS2337 error code to super call diagnostic (#18531) (camc314) - 993fd2b parser: Parse unambiguous await with better error messages (#18480) (Boshen) - 8db0e78 linter/plugins: Handle BOMs (#18376) (overlookmotel) - 6ac09e2 linter/plugins: Support source text not being at start of buffer (#18375) (overlookmotel) - 2ef5647 ast: Add escape_raw parameter to template_element builders (#18121) (Boshen) ### 🐛 Bug Fixes - 74d0998 semantic: Update error msg for multiple `default` cases in switch stmt (#18526) (camc314) - c205b0d ast: Remove `ThisExpression` from `TSModuleReference` (#18489) (Boshen) - aed3669 parser: Parse HTML-like comments in unambiguous mode (#18442) (Boshen) - c4132fb parser: Validate accessor parameters in interface method signatures (#18391) (Boshen) - b0cd74d semantic: Allow `var` and `function` with same name in static blocks (#18358) (Boshen) - 6037995 semantic: Allow `new.target` in class field initializers (#18349) (Boshen) - 9a15c6a semantic: Do not rely on spans for node comparison in `Function::bind` (#18296) (overlookmotel) ### ⚡ Performance - 6b600c4 semantic: Skip parent lookup for function declarations in `Function::bind` (#18293) (overlookmotel) - c27ad2d semantic: Move check for function declaration out of `is_function_part_of_if_statement` (#18292) (overlookmotel) - 63eb89e semantic: Skip checking redeclarations for function expressions (#18291) (overlookmotel) - 7c12743 semantic: Skip checking unresolved exports in CommonJS files (#18250) (overlookmotel) - 2349031 allocator: Increase initial chunk size from 512B to 16KB (#18234) (Boshen) ### 📚 Documentation - 8ccd853 npm: Update package homepage URLs and add keywords (#18509) (Boshen) - 9b3165f napi/parser: Clarify when to use `parseAsync` vs `parseSync` (#18486) (Boshen) - 1b59f63 napi/parser: Correct typo in README (#18251) (overlookmotel) - 00ff75f mangler: Fix `top_level` option in example (#18233) (overlookmotel) - 2ddc073 semantic: Fix typo in comment (#18238) (overlookmotel) Co-authored-by: Boshen <[email protected]>
#18168 copied `bumpalo`'s code for `Bump` into `oxc_allocator` crate. #18172, #18181, and #18234 made a few improvements to the implementation. However, #18168 removed various things, and altered others. Notably, it removed the`MIN_ALIGN` generic param, which we definitely want to keep. I'm going to be working on the allocator, and would like to start with a clean slate, beginning with the "known good" implementation of `bumpalo`. This PR removes the previous modified `bumpalo` implementation, and copies latest version of `bumpalo` from main branch into the repo. It then makes the absolute minimum changes necessary just to make CI pass. Note: Unlike #18168, this PR keeps all the doctests for `Bump`, using a trick of adding the crate to it's own `dev-dependencies` with `testing` feature enabled, and exposing `Bump` only with that feature. This PR is broken into multiple commits, so we have an exact "trail of breadcrumbs" of how we've diverged from `bumpalo`. I intend to manually merge this PR, so that record remains on Github (instead of Graphite squashing all the commits). Later PRs in this stack reapply the changes made in #18172, #18181, and #18234 on top of the fresh base implementation. This PR is a small perf regression, but that will be won back once those other changes are reapplied.
Repeat of #18234. #20963 wiped all changes to `bump.rs`, going back to a fresh copy of `bumpalo`. Re-apply changes from #18234 which were lost in the process - increasing default arena chunk size to 16 KiB, and altering `try_with_min_align_and_capacity` to respect the requested capacity in `Bump::with_capacity`. Add a comment to `try_with_min_align_and_capacity` explaining why that change is required.
Summary
FIRST_ALLOCATION_GOALfrom 512 bytes to 16 KB to reduce malloc callsBump::with_capacity()to respect exact capacity requested (otherwisewith_capacity(1024)would allocate 16KB)Malloc Reduction
Tested against 310K real-world JS/TS files:
Memory overhead increases by ~37% in allocated capacity, but actual memory used remains the same since AST size does not change.
Parser Benchmark (vs main)
Smaller/medium files show ~5% speedup from fewer malloc calls.
🤖 Generated with Claude Code