fix(linter): Fix false positive on React in consistent-type-imports#11171
Merged
graphite-app[bot] merged 1 commit intomainfrom May 19, 2025
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
DonIsaac
force-pushed
the
don/05-19-fix_linter_fix_false_positive_on_react_in_consistent-type-imports_
branch
from
0a433fe to
73302bb
Compare
CodSpeed Instrumentation Performance ReportMerging #11171 will degrade performances by 3.72%Comparing Summary
Benchmarks breakdown
|
Contributor
|
this is horrible lol |
Contributor
Merge activity
|
…#11171) ## What This PR Does Updates `typescript/consistent-type-imports` to ignore `React`. This is not a "great" solution; ideally we would be reading the user's `tsconfig.json` and using info from that to selectively ignore/report unused `React` imports. Doing this would also fix remaining false positives in this rule. This workaround should work in most cases though. I can make follow-up PR to have our lint runtime parse `tsconfig.json` files and make that data available to rules via `LintContext`. That change would potentially have large implications and lots of edge cases, so we should discuss it first.
graphite-app
Bot
force-pushed
the
don/05-19-fix_linter_fix_false_positive_on_react_in_consistent-type-imports_
branch
from
73302bb to
4104b01
Compare
graphite-app
Bot
deleted the
don/05-19-fix_linter_fix_false_positive_on_react_in_consistent-type-imports_
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What This PR Does
Updates
typescript/consistent-type-importsto ignoreReact.This is not a "great" solution; ideally we would be reading the user's
tsconfig.jsonand using info from that to selectively ignore/report unusedReactimports. Doing this would also fix remaining false positives in this rule. This workaround should work in most cases though.I can make follow-up PR to have our lint runtime parse
tsconfig.jsonfiles and make that data available to rules viaLintContext. That change would potentially have large implications and lots of edge cases, so we should discuss it first.