Skip to content

perf(linter): remove unnecessary codegen in jest/no-untyped-mock-factory#11097

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-18-perf_linter_remove_unnecessary_codegen_in_jest_no-untyped-mock-factory
May 17, 2025
Merged

perf(linter): remove unnecessary codegen in jest/no-untyped-mock-factory#11097
graphite-app[bot] merged 1 commit intomainfrom
05-18-perf_linter_remove_unnecessary_codegen_in_jest_no-untyped-mock-factory

Conversation

@shulaoda
Copy link
Contributor

@shulaoda shulaoda commented May 17, 2025

Related to #11098

Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance labels May 17, 2025
@shulaoda shulaoda changed the title perf(linter): remove unnecessary codegen in jest/no-untyped-mock-factory perf(linter): remove unnecessary codegen in jest/no-untyped-mock-factory May 17, 2025
@shulaoda shulaoda marked this pull request as ready for review May 17, 2025 16:45
@shulaoda shulaoda requested a review from camc314 as a code owner May 17, 2025 16:45
@codspeed-hq
Copy link

codspeed-hq bot commented May 17, 2025

CodSpeed Instrumentation Performance Report

Merging #11097 will not alter performance

Comparing 05-18-perf_linter_remove_unnecessary_codegen_in_jest_no-untyped-mock-factory (e8479bf) with main (dd33e57)

Summary

✅ 4 untouched benchmarks
🆕 6 new benchmarks
⁉️ 7 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⁉️ codegen[checker.ts] 22.3 ms N/A N/A
⁉️ codegen_sourcemap[checker.ts] 68.9 ms N/A N/A
⁉️ lexer[RadixUIAdoptionSection.jsx] 21.8 µs N/A N/A
⁉️ lexer[antd.js] 24.7 ms N/A N/A
⁉️ lexer[cal.com.tsx] 6 ms N/A N/A
⁉️ lexer[checker.ts] 14.7 ms N/A N/A
⁉️ lexer[pdf.mjs] 4 ms N/A N/A
🆕 estree[checker.ts] N/A 103.4 ms N/A
🆕 parser[RadixUIAdoptionSection.jsx] N/A 81.9 µs N/A
🆕 parser[antd.js] N/A 98.6 ms N/A
🆕 parser[cal.com.tsx] N/A 27.1 ms N/A
🆕 parser[checker.ts] N/A 50.6 ms N/A
🆕 parser[pdf.mjs] N/A 15.7 ms N/A

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label May 17, 2025
Copy link
Contributor

camc314 commented May 17, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 05-18-perf_linter_remove_unnecessary_codegen_in_jest_no-untyped-mock-factory branch from b696070 to e8479bf Compare May 17, 2025 20:56
@graphite-app graphite-app bot merged commit e8479bf into main May 17, 2025
18 of 25 checks passed
@graphite-app graphite-app bot deleted the 05-18-perf_linter_remove_unnecessary_codegen_in_jest_no-untyped-mock-factory branch May 17, 2025 20:59
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants