feat(language_server): tell clients to watch for .oxlintrc.json files#11078
Merged
graphite-app[bot] merged 1 commit intomainfrom May 18, 2025
Conversation
This was referenced May 16, 2025
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-editor
Sysix
changed the title
Sysix
removed
the
C-cleanup
CodSpeed Instrumentation Performance ReportMerging #11078 will not alter performanceComparing Summary
|
Sysix
force-pushed
the
05-16-refactor_language_server_restructure_initialized_function
branch
from
706d05f to
63d72a7
Compare
Sysix
force-pushed
the
feat_language_server_tell_clients_to_watch_for_.oxlintrc.json_files
branch
from
332b8ed to
9643147
Compare
Sysix
force-pushed
the
05-16-refactor_language_server_restructure_initialized_function
branch
from
63d72a7 to
b1dae1c
Compare
Sysix
force-pushed
the
feat_language_server_tell_clients_to_watch_for_.oxlintrc.json_files
branch
4 times, most recently
from
c69436f to
e5f3184
Compare
Sysix
force-pushed
the
feat_language_server_tell_clients_to_watch_for_.oxlintrc.json_files
branch
from
e5f3184 to
9c1a273
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
May 18, 2025
…dFiles.dynamicRegistration` (#11075) Current State: The client initializes the file watchers and tells the client for changes. Goal: The Server should tell clients to watch for specific files. This will help for other editors which does not have a custom implementation like VSCode does. See #11078 how to use this capability.
graphite-app
bot
changed the base branch from
05-16-refactor_language_server_restructure_initialized_function
to
graphite-base/11078
Contributor
Merge activity
|
Sysix
force-pushed
the
feat_language_server_tell_clients_to_watch_for_.oxlintrc.json_files
branch
from
9c1a273 to
26fd043
Compare
…#11078) Now it is the job of the server to watch / unwatch for files. The watching will still do the client, but the logic is now under the server's control. Changing configuration or workspaces still needs a restart because there needs to be an Identifier-Structure for all specific watcher. This will be done in the next weeks ;)
graphite-app
bot
force-pushed
the
feat_language_server_tell_clients_to_watch_for_.oxlintrc.json_files
branch
from
26fd043 to
1675b2c
Compare
graphite-app
bot
deleted the
feat_language_server_tell_clients_to_watch_for_.oxlintrc.json_files
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now it is the job of the server to watch / unwatch for files.
The watching will still do the client, but the logic is now under the server's control.
Changing configuration or workspaces still needs a restart because there needs to be an Identifier-Structure for all specific watcher. This will be done in the next weeks ;)