refactor(parser): make ParserImpl::asi implementation more compact#11037
Merged
graphite-app[bot] merged 1 commit intomainfrom May 14, 2025
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-parser
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the parser's semicolon handling to make the implementation more compact while improving performance through inlining optimizations.
- Adds #[inline] attribute to advance and can_insert_semicolon functions
- Refactors the asi function to combine token consumption and automatic semicolon insertion checks
- Updates the can_insert_semicolon function to utilize a local token variable for consistency
CodSpeed Instrumentation Performance ReportMerging #11037 will not alter performanceComparing Summary
|
Boshen
force-pushed
the
05-14-refactor_parser_make_parserimpl_asi_implementation_more_compact
branch
from
1ac210b to
c8eec29
Compare
Contributor
Merge activity
|
graphite-app
bot
force-pushed
the
05-14-refactor_parser_make_parserimpl_asi_implementation_more_compact
branch
from
c8eec29 to
919cc59
Compare
graphite-app
bot
deleted the
05-14-refactor_parser_make_parserimpl_asi_implementation_more_compact
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.