fix(ast_visit): fix visitation order for FormalParameters in Utf8ToUtf16Converter#11019
Merged
graphite-app[bot] merged 1 commit intomainfrom May 14, 2025
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 13, 2025
Merged
CodSpeed Instrumentation Performance ReportMerging #11019 will create unknown performance changesComparing Summary
Benchmarks breakdown
|
Contributor
Merge activity
|
…oUtf16Converter` (#11019) Fix visitation order in `Utf8ToUtf16Converter` to process span offsets in ascending order in `FormalParameters`. `FormalParameters`'s span starts before `TSThisParameter` that precedes it in types like `Function`, so visiting `TSThisParameter` followed by `FormalParameters` results in out-of-order span offset conversion. `FormalParameters`'s span doesn't appear in ESTree AST, so solution is just to skip converting its span entirely.
graphite-app
bot
force-pushed
the
05-13-fix_ast_visit_fix_visitation_order_for_tstemplateliteraltype_in_utf8toutf16converter_
branch
from
53a2430 to
282420c
Compare
graphite-app
bot
force-pushed
the
05-13-fix_ast_visit_fix_visitation_order_for_formalparameters_in_utf8toutf16converter_
branch
from
cc8948c to
2bdb338
Compare
Base automatically changed from
05-13-fix_ast_visit_fix_visitation_order_for_tstemplateliteraltype_in_utf8toutf16converter_
to
main
May 14, 2025 01:29
graphite-app
bot
deleted the
05-13-fix_ast_visit_fix_visitation_order_for_formalparameters_in_utf8toutf16converter_
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix visitation order in
Utf8ToUtf16Converterto process span offsets in ascending order inFormalParameters.FormalParameters's span starts beforeTSThisParameterthat precedes it in types likeFunction, so visitingTSThisParameterfollowed byFormalParametersresults in out-of-order span offset conversion.FormalParameters's span doesn't appear in ESTree AST, so solution is just to skip converting its span entirely.