Skip to content

refactor(parser/lexer): shorten code #10999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
May 13, 2025
Merged

refactor(parser/lexer): shorten code #10999

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions crates/oxc_parser/src/lexer/comment.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,10 +161,7 @@ impl<'a> Lexer<'a> {
// has a cost each time it's deref-ed. Creating `Finder` unconditionally in `Lexer::new`
// would be efficient for files containing multi-line comments, but would impose pointless
// cost on files which don't. So this is the fastest solution.
if self.multi_line_comment_end_finder.is_none() {
self.multi_line_comment_end_finder = Some(Finder::new("*/"));
}
let finder = self.multi_line_comment_end_finder.as_ref().unwrap();
let finder = self.multi_line_comment_end_finder.get_or_insert_with(|| Finder::new("*/"));

let remaining = self.source.str_from_pos_to_end(pos).as_bytes();
if let Some(index) = finder.find(remaining) {
Expand Down
Loading