Skip to content

feat(transformer, napi/transform): deprecate allowDeclareFields option #10584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Apr 25, 2025
Merged

feat(transformer, napi/transform): deprecate allowDeclareFields option #10584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion crates/oxc_transformer/src/typescript/options.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,12 @@ pub struct TypeScriptOptions {
#[serde(default = "default_as_true")]
pub allow_namespaces: bool,

// When enabled, type-only class fields are only removed if they are prefixed with the declare modifier:
/// When enabled, type-only class fields are only removed if they are prefixed with the declare modifier:
///
/// ## Deprecated
///
/// Allowing `declare` fields is built-in support in Oxc without any option. If you want to remove class fields
/// without initializer, you can use `remove_class_fields_without_initializer: true` instead.
#[serde(default = "default_as_true")]
pub allow_declare_fields: bool,

Expand Down
8 changes: 8 additions & 0 deletions napi/transform/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,6 +467,14 @@ export interface TypeScriptOptions {
jsxPragmaFrag?: string
onlyRemoveTypeImports?: boolean
allowNamespaces?: boolean
/**
* When enabled, type-only class fields are only removed if they are prefixed with the declare modifier:
*
* @deprecated
*
* Allowing `declare` fields is built-in support in Oxc without any option. If you want to remove class fields
* without initializer, you can use `remove_class_fields_without_initializer: true` instead.
*/
allowDeclareFields?: boolean
/**
* When enabled, class fields without initializers are removed.
Expand Down
6 changes: 6 additions & 0 deletions napi/transform/src/transformer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,12 @@ pub struct TypeScriptOptions {
pub jsx_pragma_frag: Option<String>,
pub only_remove_type_imports: Option<bool>,
pub allow_namespaces: Option<bool>,
/// When enabled, type-only class fields are only removed if they are prefixed with the declare modifier:
///
/// @deprecated
///
/// Allowing `declare` fields is built-in support in Oxc without any option. If you want to remove class fields
/// without initializer, you can use `remove_class_fields_without_initializer: true` instead.
pub allow_declare_fields: Option<bool>,
/// When enabled, class fields without initializers are removed.
///
Expand Down
Loading