Skip to content

perf(transformer/class-properties): re-use InstanceInitializerVisitor #10543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Apr 23, 2025
Merged

perf(transformer/class-properties): re-use InstanceInitializerVisitor #10543

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions crates/oxc_transformer/src/es2022/class_properties/instance_prop_init.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,19 +29,21 @@ impl<'a> ClassProperties<'a, '_> {
instance_inits_constructor_scope_id: Option<ScopeId>,
ctx: &mut TraverseCtx<'a>,
) {
for init in inits {
if let Some(constructor_scope_id) = instance_inits_constructor_scope_id {
// Re-parent first-level scopes, and check for symbol clashes
let mut updater = InstanceInitializerVisitor::new(
instance_inits_scope_id,
constructor_scope_id,
self,
ctx,
);
if let Some(constructor_scope_id) = instance_inits_constructor_scope_id {
// Re-parent first-level scopes, and check for symbol clashes
let mut updater = InstanceInitializerVisitor::new(
instance_inits_scope_id,
constructor_scope_id,
self,
ctx,
);
for init in inits {
updater.visit_expression(init);
} else {
// No symbol clashes possible. Just re-parent first-level scopes (faster).
let mut updater = FastInstanceInitializerVisitor::new(instance_inits_scope_id, ctx);
}
} else {
// No symbol clashes possible. Just re-parent first-level scopes (faster).
let mut updater = FastInstanceInitializerVisitor::new(instance_inits_scope_id, ctx);
for init in inits {
updater.visit_expression(init);
}
}
Expand Down
Loading