linter: `typescript/no-unecessary-type-conversion` rule does not work

[abstractalgo]

What version of Oxlint are you using?

1.52.0

What command did you run?

bun run oxlint --type-aware

What does your .oxlintrc.json (or oxlint.config.ts) config file look like?

Config is from the repro repo (see below):
https://github.com/abstractalgo/oxlint-no-unecessary-type-conversion-repro/blob/master/.oxlintrc.json

{
  "$schema": "./node_modules/oxlint/configuration_schema.json",
  "plugins": ["typescript"],
  "options": {
    "typeAware": true
  },
  "categories": {},
  "rules": {
    "typescript/no-unecessary-type-conversion": "error",
    "typescript/no-non-null-assertion": "error"
  },
  "settings": {
    "jsx-a11y": {
      "polymorphicPropName": null,
      "components": {},
      "attributes": {}
    },
    "next": {
      "rootDir": []
    },
    "react": {
      "formComponents": [],
      "linkComponents": [],
      "version": null,
      "componentWrapperFunctions": []
    },
    "jsdoc": {
      "ignorePrivate": false,
      "ignoreInternal": false,
      "ignoreReplacesDocs": true,
      "overrideReplacesDocs": true,
      "augmentsExtendsReplacesDocs": false,
      "implementsReplacesDocs": false,
      "exemptDestructuredRootsFromChecks": false,
      "tagNamePreference": {}
    },
    "vitest": {
      "typecheck": false
    }
  },
  "env": {
    "builtin": true
  },
  "globals": {},
  "ignorePatterns": []
}

What happened?

oxlint 1.52.0 added this rule (release notes), but it's not working.

Here's the repro repo: https://github.com/abstractalgo/oxlint-no-unecessary-type-conversion-repro

As a comparison, I added a second typescript/* rule, and that one does work.

Repro: bun i + bun run oxlint + see /src/App.tsx file for where the error is supposed to be reported

Alternative repro on oxc playground.

[camc314]

It looks like you don't have type aware linting enabled.

Either add:

--type-aware when running the CLI

or add

{
    "options": { "typeAware": true }
}

to your oxlint configuration

[abstractalgo]

I wasn't, but even with it - the result is the same. (I updated the repro repo)

(It's curious that typescript/no-non-null-assertion rule was getting reported despite not using the type aware CLI flag nor having an option in the config.) (I also have it in .vscode/settings.json)

[camc314]

https://github.com/abstractalgo/oxlint-no-unecessary-type-conversion-repro/blob/aee51387263ecba620f6865a572a7247084766e8/.oxlintrc.json#L6

The rule name is spelt incorreclty.

It should be:

   "plugins": ["typescript"],
   "categories": {},
   "rules": {
-    "typescript/no-unecessary-type-conversion": "error",
+    "typescript/no-unnecessary-type-conversion": "error",
     "typescript/no-non-null-assertion": "error"
   },
   "settings": {

[abstractalgo]

I am so sorry for time waste - can confirm it works 🙌

EDIT: to be fair, I did copy it from the PR title 😄

[camc314]

EDIT: to be fair, I did copy it from the #19955 😄

haha there goes to my lack of ability to spell.

I think i'd been staring at the word for so long even the correct version looks wrong.

[abstractalgo]

an idea: ESlint does report when the config is misconfigured; could be a nice QoL improvement for oxlint to do that as well at some point.

[camc314]

yep agreed