linter: "multi-or-nest", "consistent" conflicts

[Mister-Hope]

What version of Oxlint are you using?

latest

What command did you run?

oxlint

What does your .oxlintrc.json config file look like?

{
  // ...
  "rules": {
        "curly": ["warn", "multi-or-nest", "consistent"],
  }
} 

What happened?

A nested if/else if with:

• if multiline
• else if single line

will never pass curly rule.

  while (state.pos < max) {
    if (dividerPosition) {
      if (
        state.src.charCodeAt(state.pos) === 125 /* } */ &&
        state.src.charCodeAt(state.pos - 1) !== 92 /* \ */
      ) {
        closePos = state.pos;
        break;
      }
    } else if (
      state.src.charCodeAt(state.pos) === 58 /* : */ &&
      state.src.charCodeAt(state.pos - 1) !== 92 /* \ */
    ) {
      dividerPosition = state.pos;
    }

    state.pos++;
  }

multi-or-nest will suggest the else if removing the braces.

  while (state.pos < max) {
    if (dividerPosition) {
      if (
        state.src.charCodeAt(state.pos) === 125 /* } */ &&
        state.src.charCodeAt(state.pos - 1) !== 92 /* \ */
      ) {
        closePos = state.pos;
        break;
      }
    } else if (
      state.src.charCodeAt(state.pos) === 58 /* : */ &&
      state.src.charCodeAt(state.pos - 1) !== 92 /* \ */
    ) 
      dividerPosition = state.pos;


    state.pos++;
  }

The consistent will suggest adding the braces.

In short, case 1 is a false positive which curly rule should recognize the brance is necessary and not try to auto fix by removing braces.

[Mister-Hope]

Besides, the docs are wrong: https://oxc.rs/docs/guide/usage/linter/rules/eslint/curly.html#configuration

It says: This rule accepts a configuration object with the following properties:

While the following do not work at all and fallback to default behavior:

    "curly": ["warn", { "curlyType": "multi-or-nest", "consistent": true }],

The plugin is still expecting a old eslint-style configuration same as comments in the documentation:

/* curly: ["error", "multi-or-nest", "consistent"] */

This rule accepts a configuration object with the following properties:

If oxlint does not support this, the above wording MUST be improved; it is confusing to use "accepts a configuration object with the following properties" while it does not.

[camc314]

fixed by #18660