☂️ eslint-plugin-import

[Boshen]

Warning

This comment is maintained by CI. Do not edit this comment directly.
To update comment template, see https://github.com/oxc-project/oxc/tree/main/tasks/lint_rules

This is the tracking issue for eslint-plugin-import.

There are 45(+ 1 deprecated) rules.

• 0/8 recommended rules are remaining as TODO
  • 1 of which have pending fixes
  • All done! 🎉
• 8/37 not recommended rules are remaining as TODO
  • 3 of which have pending fixes

To get started, run the following command:

just new-import-rule <RULE_NAME>

Then implement the rule and get all the tests passing.

Recommended rules

✅: 7, 🚫: 1, ⏳: 1 / total: 8

Status	Name	Rationale
✅	import/default
✅	import/export
✅	import/named
✅	import/namespace
✅⏳	import/no-duplicates
✅	import/no-named-as-default
✅	import/no-named-as-default-member
🚫	import/no-unresolved	Will always contain false positives due to module resolution complexity.

✅ = Implemented, 🚫 = Not intending to implement, ⏳ = Fix pending

Not recommended rules

✅: 25, 🚫: 4, ⏳: 3 / total: 37

Status	Name	Rationale
✅	import/consistent-type-specifier-style
	import/dynamic-import-chunkname
🚫	import/enforce-node-protocol-usage	No need to implement, already implemented by unicorn/prefer-node-protocol.
✅	import/exports-last
✅	import/extensions
✅⏳	import/first
✅	import/group-exports
✅	import/max-dependencies
	import/newline-after-import
✅⏳	import/no-absolute-path
✅	import/no-amd
✅	import/no-anonymous-default-export
✅	import/no-commonjs
✅	import/no-cycle
✅	import/no-default-export
🚫	import/no-deprecated	No need to implement, already implemented by typescript/no-deprecated via tsgolint.
✅	import/no-dynamic-require
✅	import/no-empty-named-blocks
	import/no-extraneous-dependencies
	import/no-import-module-exports
🚫	import/no-internal-modules	Not necessary to implement this rule as we already have eslint/no-restricted-imports, which is able to cover the same use-cases.
✅	import/no-mutable-exports
✅	import/no-named-default
✅	import/no-named-export
✅⏳	import/no-namespace
✅	import/no-nodejs-modules
	import/no-relative-packages
✅	import/no-relative-parent-imports
	import/no-restricted-paths
✅	import/no-self-import
✅	import/no-unassigned-import
	import/no-unused-modules
	import/no-useless-path-segments
✅	import/no-webpack-loader-syntax
🚫	import/order	Not implementing this in Oxlint as its behavior is covered very well by Oxfmt's import sorting.
✅	import/prefer-default-export
✅	import/unambiguous

✅ = Implemented, 🚫 = Not intending to implement, ⏳ = Fix pending

Deprecated rules

✅: 0, 🚫: 1, ⏳: 0 / total: 1

Status	Name	Rationale
🚫	import/imports-first	Replaced by import/first, which we support.

✅ = Implemented, 🚫 = Not intending to implement, ⏳ = Fix pending

[XantreDev]

Sponsorship link is broken

[XantreDev]

I think it kind of trivial to implement export rule

[XantreDev]

It's already implemented, checkboxes are obsolete

[camc314]

Sponsorship link is broken

fixed

It's already implemented, checkboxes are obsolete

updated

[XantreDev]

@Boshen seems to be for implementing no-named-as-default we need to provide also Atom in ModuleRecord for export_default (to get export default identifier name).

Can I try to add it? Maybe there are other way to do it?

[Boshen]

@XantreGodlike To be honest I don't really get this rule, and there's so many issues with it https://github.com/search?q=repo%3Aimport-js%2Feslint-plugin-import+no-named-as-default&type=issues

But for default exports, you may add a Option<Atom> because you can default export a function, which may not have a name.

[yordis]

yarn pnp support is huge for us 🙏🏻 🙏🏻 🙏🏻 🙏🏻 🙏🏻 🙏🏻 🙏🏻 🙏🏻 🙏🏻 🙏🏻 🙏🏻 🙏🏻 🙏🏻

[XantreDev]

@yordis Is it separate rule?

[XantreDev]

There is no new-import-rule