Skip to content

CodegenOptions::print_legal_comment doesn't make any effect #10948

@hyf0

Description

@hyf0

When I try to print legal comments only with using oxc, I found, with passing

CodegenOptions {
  comments: false,
  legal_comments: LegalComment::Inline,
  ..
}

won't print legal/any comment.

Image

The field is not used.

print_legal_comment: bool,

Image

Context:

  • Rolldown follows esbuild's way to handle comments.
  • Esbuild only preserve legal and annoatation comments.
  • Rolldown intend to ensure this behavior too.

Metadata

Metadata

Assignees

Labels

P-highPriority - High

Type

Priority

None yet

Effort

None yet

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions