Skip to content

Create TypeCheckSFTP.php#41309

Closed
harrykipper wants to merge 1 commit into
owncloud:masterfrom
harrykipper:patch-1
Closed

Create TypeCheckSFTP.php#41309
harrykipper wants to merge 1 commit into
owncloud:masterfrom
harrykipper:patch-1

Conversation

@harrykipper

Copy link
Copy Markdown

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@harrykipper

Copy link
Copy Markdown
Author

Add changelog item for pull request 41240

@harrykipper harrykipper reopened this Aug 19, 2024
@iasdeoupxe

Copy link
Copy Markdown
Contributor

Shouldn't this go directly into #41240 and instead of changelog/unreleased/TypeCheckSFTP.php the file should be just called changelog/unreleased/41240?

@phil-davis

Copy link
Copy Markdown
Contributor

Yes, the changelog needs to go into PR #41240 - the file name of the changelog does not matter so much, but we have been conventionally using the PR number 41240 as the name of the changelog file.

@iasdeoupxe iasdeoupxe mentioned this pull request Sep 5, 2024
9 tasks

@DeepDiver1975 DeepDiver1975 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review — Create TypeCheckSFTP.php (changelog entry for #41240)

This PR adds only a changelog entry in changelog/unreleased/ for the SFTP type-check fix (issue #41159). The actual code change is in PR #41240.

Note: The changelog file is named TypeCheckSFTP.php — changelog files should follow the numeric PR number convention (e.g. 41240) as used consistently throughout changelog/unreleased/. The .php extension and descriptive filename are non-standard for this directory. Recommend renaming to 41309 (this PR's number) or 41240 (the PR it documents) to match convention.

The content of the changelog entry itself is accurate.

Verdict: Needs minor fix — rename the changelog file to follow the numeric convention (41309 or 41240). Otherwise ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants