Create TypeCheckSFTP.php#41309
Conversation
|
Add changelog item for pull request 41240 |
|
Shouldn't this go directly into #41240 and instead of |
|
Yes, the changelog needs to go into PR #41240 - the file name of the changelog does not matter so much, but we have been conventionally using the PR number |
DeepDiver1975
left a comment
There was a problem hiding this comment.
Code Review — Create TypeCheckSFTP.php (changelog entry for #41240)
This PR adds only a changelog entry in changelog/unreleased/ for the SFTP type-check fix (issue #41159). The actual code change is in PR #41240.
Note: The changelog file is named TypeCheckSFTP.php — changelog files should follow the numeric PR number convention (e.g. 41240) as used consistently throughout changelog/unreleased/. The .php extension and descriptive filename are non-standard for this directory. Recommend renaming to 41309 (this PR's number) or 41240 (the PR it documents) to match convention.
The content of the changelog entry itself is accurate.
Verdict: Needs minor fix — rename the changelog file to follow the numeric convention (41309 or 41240). Otherwise ready to merge.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: