Adding detailed mode to occ security:routes

[DeepDiver1975]

Description

Related Issue

refs https://github.com/owncloud/enterprise/issues/2207

Whats missing?

• no annotations for controllers which are not resolved via their class name https://github.com/owncloud/diagnostics/blob/master/lib/AppInfo/Application.php#L62
• all controllers in core - because they are named \OC\Core and not \OCA...
• ocs routes need a second look

How Has This Been Tested?

Manual local testing ...

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[PVince81]

what about Webdav routes ?

[PVince81]

do we expect this to make it in 10.0.3 or defer to planned for 10.0.4 ?

[PVince81]

moving to "triage"

[phil-davis]

done differently in #28901
@DeepDiver1975 @butonic close here?

[butonic]

nice

[jvillafanez]

Is it possible to "merge" these 2 loops in order to avoid looping through the list twice?

[DeepDiver1975]

in line 74 the list of collections is compressed to on list of routes

[PVince81]

premature optimization might not be needed here, considering that this code rarely runs and the number of entries should be small

[jvillafanez]

I meant something like:

foreach ($this->router->getCollections() as $c) {
  $new = $c->all();
  foreach ($new as $name => $route) {
    ....
    $rows[] = array_merge(.....);
  }
}

need to be careful with the $c variable in this case.

[jvillafanez]

Move this implode to the row creation (lines 97 and 81) to avoid another list traversal?

[DeepDiver1975]

not really because in line 93 there is a array merge

[jvillafanez]

In line 100 you have sort ($rows[$path]['methods']);. You can make the implode after that unless you need the array for something else.
Adjustment will be needed for the other case (lines 81-82)

[jvillafanez]

I'd add a comment in listControllerNames and listMethodNames to make sure those are used as generators, or maybe change the name to make clear that they'll return generators, not lists.

[mmattel]

@butonic pls create a documentation PR to reflect the new option

[DeepDiver1975]

@butonic @PVince81 backport?

[PVince81]

please backport for 10.0.4

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.