Add navigation via info.xml #26785
Merged
Add navigation via info.xml #26785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DeepDiver1975, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bartv2, @PVince81 and @tanghus to be potential reviewers. |
DeepDiver1975
force-pushed
the
add-navigation-via-info.xml
branch
from
ca74177 to
cbdb5cd
Compare
DeepDiver1975
force-pushed
the
add-navigation-via-info.xml
branch
from
cbdb5cd to
dd51a56
Compare
PVince81
reviewed
Dec 8, 2016
| $icon = $this->urlGenerator->imagePath($app, $i); | ||
| break; | ||
| } catch (\RuntimeException $ex) { | ||
| } |
Contributor
There was a problem hiding this comment.
missing comment to justify ignoring exception
Contributor
|
👍 otherwise |
Contributor
|
little regression here #27839 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Navigation entries are now setup in info.xml.
Old was will still stay valid.
Motivation and Context
Navigation elements are read from info.xml only up on necessity to build up the menu.
By moving more and more out of app.php we can improve the overall performance.
Types of changes
Checklist:
ToDos: