[user mgnt] fix delete user feedback on failure

[MorrisJobke]

• fixes JS TypeError when deleting user #18099

To reproduce the failure case change the condition of the if in https://github.com/owncloud/core/blob/637edfde24eefd9e9723ce3d438a7d627059681c/settings/controller/userscontroller.php#L393-393 to true.

Before:

• no error message shown - looks like delete was successful

After:

• error message
• user is added to the user list again

[MorrisJobke]

Use the whitespace cleaned diff: https://github.com/owncloud/core/pull/18114/files?w=1

[MorrisJobke]

cc @blizzz @PVince81 @oparoz

[MorrisJobke]

@karlitschek Just tested it and it is also broken on stable8 and stable8.1. I would like to backport this then.

[DeepDiver1975]

Just tested it and it is also broken on stable8 and stable8.1.

in this case it's not a regression 🙊

[MorrisJobke]

in this case it's not a regession 🙊

It's a regression, because it worked in stable7 and broke during the move of the ajax files to a user controller ;)

[MorrisJobke]

Was introduced in #12618

@LukasReschke You also now have the opportunity to review this :P

[scrutinizer-notifier]

A new inspection was created.

[MorrisJobke]

I fixed the unit tests.

@PVince81 @blizzz Please review

[PVince81]

👍

[ghost]

🚀 Test PASSed.🚀

[MorrisJobke]

@Xenopathic @rullzer @LukasReschke @blizzz @oparoz Please review :)

[oparoz]

Works! 👍

[MorrisJobke]

@karlitschek What about the backport to stable8 and stable8.1?

[MorrisJobke]

@karlitschek What about the backport to stable8 and stable8.1?

Ping.

[karlitschek]

please backport!

[MorrisJobke]

stable8.1 #18566
stable8 #18567

[MorrisJobke]

Issue noticed during the backports: #20254