Mail address of users is now changable in the user management #12921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
MorrisJobke
force-pushed
the
user-mail-user-management
branch
from
5fcbb12 to
9c9aec0
Compare
Member
|
@owncloud-bot Retest this please. |
Member
|
tested - works 👍 |
Member
|
as discussed - please verify lost password screen is not broken - THX |
MorrisJobke
force-pushed
the
user-mail-user-management
branch
from
9c9aec0 to
71bcdec
Compare
Contributor
Author
|
Rebased |
* introduced new route settings/users/{id}/mailAddress
* kept old responses
* better error messages
* dropped lostpassword.php from settings/ajax
* cleaned up the UserList.add() and hand in user object instead of
each attribute as another parameter
* check for change permission of mail address
* proper response messages
MorrisJobke
force-pushed
the
user-mail-user-management
branch
from
71bcdec to
5913af8
Compare
Contributor
Author
|
Tested and still works :) |
|
The inspection completed: 15 new issues, 9 updated code elements |
Contributor
Author
|
Jenkins PR #12952 |
Contributor
Author
|
@owncloud-bot retest this please |
|
Refer to this link for build results (access rights to CI server needed): Build result: FAILURE[...truncated 17 lines...]using GIT_SSH to set credentials using .gitcredentials to set credentials > git config --local credential.helper store --file=/tmp/git5847736303688410432.credentials # timeout=10 > git fetch --tags --progress https://github.com/owncloud/core.git +refs/pull/:refs/remotes/origin/pr/ > git config --local --remove-section credential # timeout=10 > git rev-parse origin/pr/12921/merge^{commit} # timeout=10 > git branch -a --contains 254db24ef848100a1181b9fc863b92eeb5f4eae2 # timeout=10 > git rev-parse remotes/origin/pr/12921/merge^{commit} # timeout=10Checking out Revision 254db24ef848100a1181b9fc863b92eeb5f4eae2 (origin/pr/12921/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f 254db24ef848100a1181b9fc863b92eeb5f4eae2 > git rev-list 7261c782c54e5deb2c60309e58943168b53c57eb # timeout=10First time build. Skipping changelog. > git remote # timeout=10 > git submodule init # timeout=10 > git submodule sync # timeout=10 > git config --get remote.origin.url # timeout=10 > git submodule update --init --recursiveTriggering pull-request-analyser-ng-simple » SLAVEpull-request-analyser-ng-simple » SLAVE completed with result FAILUREStarted calculate disk usage of buildFinished Calculation of disk usage of build in 0 secondsStarted calculate disk usage of workspaceFinished Calculation of disk usage of workspace in 2 secondTest FAILed. |
Member
DeepDiver1975
added a commit
that referenced
this pull request
Dec 19, 2014
Mail address of users is now changable in the user management
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
each attribute as another parameter
fixes #12595
ref #12620
cc @blizzz @DeepDiver1975 @PVince81 @LukasReschke
re-incarnation of #12853