fix: query parameters None should be JSON encoded and empty query params should not be sent #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ams should not be sent Signed-off-by: Romain Beuque <[email protected]>
rbeuque74
force-pushed
the
remove-empty-trailing-query-params-and-None-value
branch
from
dfa91d7 to
439b542
Compare
rbeuque74
added a commit
that referenced
this pull request
Mar 8, 2022
Includes #107 with #102 fixes. Signed-off-by: Romain Beuque <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #99 and #101, I change the behaviour when
Noneis sent as a query parameter.Also, do not send an empty query string
?when no kwargs are provided.