refactor: ESmoduleにすべて統一。バージョンが古いと新しいバージョンありますと表示する機能を追加 - #26
Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
📝 WalkthroughWalkthrough
ChangesCLI機能拡張と発行フロー改善
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (3 warnings)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 16 minutes and 37 seconds.Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🧹 Nitpick comments (1)
apps/cli/README.md (1)
43-43: ⚡ Quick winドキュメント内のフレームワーク表記を統一してください
Line [43] の
LismUI-Vueは、ドキュメント規約上LismCSSに統一が必要です。As per coding guidelines,
**/*.{md,markdown,txt}: In documentation, use the capitalized name 'LismCSS' when referring to the framework.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/cli/README.md` at line 43, Replace the framework name string "LismUI-Vue" with the standardized, capitalized name "LismCSS" in the README content (the occurrence shown in the diff); ensure any other instances in this document use "LismCSS" to comply with the docs naming convention for files matching **/*.{md,markdown,txt}.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/cli/cmd/check.go`:
- Around line 73-75: The branch that detects Nuxt (isNuxt &&
pkg.Dependencies["@lism-ui-vue/nuxt"] != "" ||
pkg.DevDependencies["@lism-ui-vue/nuxt"] != "") logs a skip via
pterm.Warning.Println but then incorrectly sets allPassed = false; remove or
stop setting allPassed to false in this skip branch so the overall check remains
successful when skipped (leave allPassed unchanged or explicitly set to true),
keeping the skip message and behavior in the same conditional referencing
isNuxt, pkg.Dependencies/DevDependencies and pterm.Warning.Println.
In `@apps/cli/package.json`:
- Around line 29-30: The package.json currently lists "update-notifier" under
devDependencies which causes ERR_MODULE_NOT_FOUND at runtime when
apps/cli/wrapper.js imports it; move the "update-notifier" entry from
devDependencies into dependencies in the package.json so it is installed for end
users, then run npm/yarn install and verify apps/cli/wrapper.js can import
update-notifier without error.
In `@apps/cli/scripts/publish-npm.js`:
- Around line 77-80: The current loop silently skips missing binaries by
checking fs.existsSync(binaryPath) and continuing, which can lead to publishing
the root package while subpackages are missing; instead, collect missing
binaryFileName entries during the loop (using binaryPath/binaryFileName as
identified), and before performing the root publish step, if the missing list is
non-empty log an error listing the missing binaries and abort (throw or
process.exit(1)) to prevent the root publish; ensure the check runs prior to the
code that does the root publish so the script fails fast when any subpackage
binary is missing.
In `@apps/cli/wrapper.js`:
- Around line 35-37: import.meta.resolve() が返す URL 文字列をそのまま
path.dirname()/path.join() に渡しているためファイルパスが壊れています。pkgJsonPath を
fileURLToPath(import.meta.resolve(`${pkgName}/package.json`)) のように変換してから使用し、以降の
pkgDir = path.dirname(pkgJsonPath) と binPath = path.join(pkgDir,
getBinaryFileName(platform)) が正しいファイルパスを参照するように修正してください（参照シンボル:
import.meta.resolve, fileURLToPath, pkgJsonPath, pkgDir, binPath,
getBinaryFileName）。
- Line 7: The JSON import line using "import pkg from './package.json' with {
type: 'json' }" is not stable on supported Node targets; either update
package.json "engines.node" to ">=23.1.0" to allow that syntax, or replace the
import in wrapper.js with a runtime read/parse: synchronously read
'./package.json' (e.g., using fs.readFileSync) and JSON.parse it into the
existing pkg variable; ensure references to pkg continue to work and remove the
experimental import form.
---
Nitpick comments:
In `@apps/cli/README.md`:
- Line 43: Replace the framework name string "LismUI-Vue" with the standardized,
capitalized name "LismCSS" in the README content (the occurrence shown in the
diff); ensure any other instances in this document use "LismCSS" to comply with
the docs naming convention for files matching **/*.{md,markdown,txt}.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: b57725c0-310e-43be-abc8-d164a28b7166
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (8)
apps/cli/README.mdapps/cli/cmd/check.goapps/cli/cmd/root.goapps/cli/package.jsonapps/cli/scripts/publish-npm.jsapps/cli/wrapper-utils.jsapps/cli/wrapper.jsapps/cli/wrapper.test.js
…をリファクタリング Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
リリースノート
新機能
checkコマンドが Nuxt プロジェクトの依存関係検出に対応し、より正確な診断を提供ドキュメント
checkコマンドの詳細説明と検証項目を追加テスト
リファクタリング