Refactor IOMarket Extracted into tfs::IOMarket namespace#4976
Merged
ArturKnopik merged 2 commits intootland:masterfrom Oct 5, 2025
Merged
Refactor IOMarket Extracted into tfs::IOMarket namespace#4976ArturKnopik merged 2 commits intootland:masterfrom
ArturKnopik merged 2 commits intootland:masterfrom
Conversation
ranisalt
reviewed
Jul 26, 2025
src/iomarket.h
Outdated
| static MarketOfferEx getOfferByCounter(uint32_t timestamp, uint16_t counter); | ||
|
|
||
| static void createOffer(uint32_t playerId, MarketAction_t action, uint32_t itemId, uint16_t amount, uint64_t price, | ||
| namespace tfs::IOMarket { |
Member
There was a problem hiding this comment.
Namespaces should be lowercase, so tfs::iomarket
All credits to @ramon-bernardo, I just used his PR that had been forcibly closed and created this new PR The goal is to continue the refactoring process for namespaces in functions
alysonjacomin
force-pushed
the
namespace-IOMarket
branch
from
2790d97 to
bc5e066
Compare
ranisalt
approved these changes
Jul 26, 2025
ArturKnopik
approved these changes
Oct 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
All credits to @ramon-bernardo, I just used his PR #4690 that had been forcibly closed and created this new PR
The goal is to continue the refactoring process for namespaces in functions