feat: make HTTP listen on the same IP as OTS#4958
Merged
ArturKnopik merged 5 commits intootland:masterfrom Jul 10, 2025
Merged
Conversation
ranisalt
reviewed
Jul 5, 2025
ranisalt
reviewed
Jul 5, 2025
Member
|
@Shawak can you confirm this solves the initial issue with Docker? |
Contributor
|
I didnt test it but it should since the game server now binds on ip address any (not sure if it only works for |
Contributor
Author
Tested on Windows (.exe) and using Docker with Linux container, in both cases bind to |
ArturKnopik
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to host OTS inside docker with working HTTP server.
After changes from this commit (and #4957 ), you can run local server inside docker with server IP set to
127.0.0.1inconfig.lua.It also fixes problem described in #4945
Example
docker-compose.yaml:docker/data.sqlfile to create accounttfs@tfswith passwordtfsand characterGOD: