fix: crash in ProtocolLogin (#4902)#4926
Conversation
|
My PR fails on code style, because useless - there is no case in TFS code that could crash #4924 fixes code style in @ArturKnopik |
I think the builds are broken anyway, it doesn't matter if you fix the code format in that place. |
MillhioreBT
left a comment
There was a problem hiding this comment.
Regarding this PR, it's very rare for someone to suffer from this issue, since the old protocol is supposedly no longer used. Now, the HTTP protocol is used to fetch the character list, but I still think this IF statement is fine there.
Pull Request Prelude
Changes Proposed
ProtocolLogin::getCharacterListreads IP fromgetConnection()in dispatcher event, but does not check, if connection still exists.Without connection, whole login process can be skipped, as there is no way to return list of characters to Tibia Client.
Fixes crash reported in #4902