Skip to content

Refactor database: Extracted into tfs::db namespace#4858

Closed
ramon-bernardo wants to merge 6 commits intootland:masterfrom
ramon-bernardo:db-namespace
Closed

Refactor database: Extracted into tfs::db namespace#4858
ramon-bernardo wants to merge 6 commits intootland:masterfrom
ramon-bernardo:db-namespace

Conversation

@ramon-bernardo
Copy link
Contributor

@ramon-bernardo ramon-bernardo commented Nov 25, 2024

Pull Request Prelude

Changes Proposed

  • Nothing complicated here; Database has been moved to tfs::db.

See

  • The Database singleton has been removed from DatabaseTasks. The system now uses the tfs::db namespace for managing the db, maintaining a single connection (which could potentially have drawbacks).

}

std::cout << " MySQL " << Database::getClientVersion() << std::endl;
std::cout << " MySQL " << tfs::db::client_version() << std::endl;

Check warning

Code scanning / CodeQL

Potential exposure of sensitive system data to an unauthorized control sphere

This operation potentially exposes sensitive system data from [*call to mysql_get_client_info](1).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant