Fix use-after-free in creature conditions#4726
Merged
EvilHero90 merged 1 commit intootland:masterfrom Jun 4, 2024
Merged
Conversation
EvilHero90
added
enhancement
ghost
requested review from
ghost
approved these changes
Jun 4, 2024
ranisalt
approved these changes
Jun 4, 2024
Member
ranisalt
left a comment
ranisalt
left a comment
There was a problem hiding this comment.
Good catch. It is probably better to use smart pointers here, but this is a good stop-gap.
csantbr
pushed a commit
to csantbr/forgottenserver-downgrades
that referenced
this pull request
Dec 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Creatureclass destructor loops over theconditionsmember variable and callscondition->endConditionthendeletes the condition object, however,ConditionInvisible::endConditioncallsCreature::isInvisible, which subsequently loops over theconditions(which are not erased when being deleted in the destructor), callingcondition->getTypeon an already deleted memory, resulting in UAF. This fixes the issue by first ending all conditions, then deleting them separately (as erasing the elements one-by-one in theCreaturedestructor does not make much sense).