Set correct minimum dependency versions#4720
Merged
ranisalt merged 1 commit intootland:masterfrom Jun 2, 2024
Merged
Conversation
ghost
approved these changes
Jun 2, 2024
EvilHero90
approved these changes
Jun 2, 2024
Contributor
EvilHero90
left a comment
EvilHero90
left a comment
There was a problem hiding this comment.
I'm fine with that, if most common OS support everything then why not
EvilHero90
added
enhancement
csantbr
pushed a commit
to csantbr/forgottenserver-downgrades
that referenced
this pull request
Dec 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
The minimum dependency versions are outdated and set too low. For the HTTP server, Boost 1.75 is the minimum required version. Furthermore, the most outdated still supported Ubuntu version, 20.04 LTS, ships Boost 1.71, it is pointless to support anything before
fmt8.1.0 is a lot faster than 6.1.2 and also widely available. It has gotten support for formatting time points and named arguments which I intend to useCMake 3.19 is already a requirement for the preset feature that we already use